Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Fix copy, typo in code snippet #156049

Merged
merged 1 commit into from
Apr 27, 2023
Merged

[Enterprise Search] Fix copy, typo in code snippet #156049

merged 1 commit into from
Apr 27, 2023

Conversation

leemthompo
Copy link
Contributor

@leemthompo leemthompo commented Apr 27, 2023 •
edited by kibanamachine
Loading

  • Updates copy
  • Removes stray "6" from start of Search UI snippet

capture

@leemthompo leemthompo added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.8.0 labels Apr 27, 2023
@leemthompo leemthompo self-assigned this Apr 27, 2023
@leemthompo leemthompo requested a review from a team April 27, 2023 17:02
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@leemthompo leemthompo enabled auto-merge (squash) April 27, 2023 17:39
@leemthompo leemthompo merged commit f9d7655 into elastic:main Apr 27, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.3MB 2.3MB -68.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @leemthompo

@kibanamachine kibanamachine mentioned this pull request Apr 27, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 27, 2023
@leemthompo
[Enterprise Search] Fix copy, typo in code snippet (elastic#156049)
fa2e2cd 
(cherry picked from commit f9d7655)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@leemthompo leemthompo deleted the liamthompson/ent-search-copyedit branch April 27, 2023 18:10
kibanamachine added a commit that referenced this pull request Apr 27, 2023
@kibanamachine @leemthompo
[8.8] [Enterprise Search] Fix copy, typo in code snippet (#156049) (#…
cbd8a70 
…156072)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Enterprise Search] Fix copy, typo in code snippet
(#156049)](#156049)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Liam
Thompson","email":"32779855+leemthompo@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-04-27T18:02:57Z","message":"[Enterprise
Search] Fix copy, typo in code snippet
(#156049)","sha":"f9d7655157f502b6288a534aca1d0246d8f20459","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.8.0","v8.9.0"],"number":156049,"url":"#156049
Search] Fix copy, typo in code snippet
(#156049)","sha":"f9d7655157f502b6288a534aca1d0246d8f20459"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"#156049
Search] Fix copy, typo in code snippet
(#156049)","sha":"f9d7655157f502b6288a534aca1d0246d8f20459"}}]}]
BACKPORT-->

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kderusso kderusso kderusso approved these changes

@sphilipse sphilipse sphilipse approved these changes

Assignees

@leemthompo leemthompo

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@leemthompo @apmmachine @kibana-ci @kibanamachine @kderusso @sphilipse