Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add more cypress test for the agent list page #156087

Merged
merged 10 commits into from
May 1, 2023

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Apr 27, 2023

Summary

Resolve #134085
Add more cypress tests to the agent list table

Agent Table

  • tags filtering

Bulk Actions

  • bulk upgrade with cancel
  • edit tags
  • Reassing policy

There is some flakyness in the test that I mitigated by using some wait on the GET /agents API request, but a proper solution will probably to migrate that page to react-query #156199

@nchaulet nchaulet added the release_note:skip Skip the PR/issue when compiling release notes label Apr 27, 2023
@nchaulet nchaulet self-assigned this Apr 27, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@nchaulet nchaulet marked this pull request as ready for review April 28, 2023 17:00
@nchaulet nchaulet requested a review from a team as a code owner April 28, 2023 17:00
@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Apr 28, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet
Copy link
Member Author

nchaulet commented May 1, 2023

@elasticmachine merge upstream

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests LGTM - did not run locally but results look good in CI. 🚀

@nchaulet nchaulet enabled auto-merge (squash) May 1, 2023 15:41
@nchaulet
Copy link
Member Author

nchaulet commented May 1, 2023

@elasticmachine merge upstream

@nchaulet
Copy link
Member Author

nchaulet commented May 1, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #9 / machine learning - short tests model management trained models for ML power user with imported models stops deployment of the imported model pt_tiny_ner

Metrics [docs]

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
fleet 28 29 +1
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 479 482 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit 7588a96 into elastic:main May 1, 2023
@kibanamachine kibanamachine added v8.9.0 backport:skip This commit does not require backporting labels May 1, 2023
@nchaulet nchaulet deleted the feature-fleet-agent-cypress-tests branch May 1, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Add Cypress tests for agents table
6 participants