[Fleet] [Message Signing] Respond with a generic error when rotate key pair fails #156144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashokaditya
added
release_note:skip
ashokaditya
force-pushed
the
tsk/dw-rotate-key-pair-api-error-response
branch
from
305736c
to
83eefa2
Compare
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
review changes @dasansol92 follow up of elastic/pull/155864
ashokaditya
force-pushed
the
tsk/dw-rotate-key-pair-api-error-response
branch
from
83eefa2
to
5778d80
Compare
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
nchaulet
reviewed
Apr 28, 2023
| @@ -41,6 +41,6 @@ export const rotateKeyPairHandler: FleetRequestHandler< | |||
| }); | |||
| } catch (error) { | |||
| logger.error(error.meta); | |||
There was a problem hiding this comment.
should we log the whole error instead of error.meta here?
There was a problem hiding this comment.
Yeah, why not. I'll update it.
review changes @nchaulet
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @ashokaditya |
joeypoon
approved these changes
Apr 28, 2023
dasansol92
approved these changes
Apr 28, 2023
Here's a screenshot of logging the error from the tests that goes into |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 28, 2023
…y pair fails (elastic#156144) ## Summary Responds with a generic error message for the rotate key pair API, instead of a trace message of where the error was generated. We log the detailed errors and this is to avoid a chance of any sensitive data (key generation details) being exposed through the API response. follow up of elastic/pull/155864 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 13486f5)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 28, 2023
…ate key pair fails (#156144) (#156188) # Backport This will backport the following commits from `main` to `8.8`: - [[Fleet] [Message Signing] Respond with a generic error when rotate key pair fails (#156144)](#156144) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ashokaditya","email":"1849116+ashokaditya@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-04-28T15:17:06Z","message":"[Fleet] [Message Signing] Respond with a generic error when rotate key pair fails (#156144)\n\n## Summary\r\n\r\nResponds with a generic error message for the rotate key pair API,\r\ninstead of a trace message of where the error was generated.\r\n\r\nWe log the detailed errors and this is to avoid a chance of any\r\nsensitive data (key generation details) being exposed through the API\r\nresponse.\r\n\r\nfollow up of /pull/155864\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"13486f50deb6070f4e9ab00de63827caf0ed6040","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","Team:Defend Workflows","OLM Sprint","v8.8.0","v8.9.0"],"number":156144,"url":"https://github.com/elastic/kibana/pull/156144","mergeCommit":{"message":"[Fleet] [Message Signing] Respond with a generic error when rotate key pair fails (#156144)\n\n## Summary\r\n\r\nResponds with a generic error message for the rotate key pair API,\r\ninstead of a trace message of where the error was generated.\r\n\r\nWe log the detailed errors and this is to avoid a chance of any\r\nsensitive data (key generation details) being exposed through the API\r\nresponse.\r\n\r\nfollow up of /pull/155864\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"13486f50deb6070f4e9ab00de63827caf0ed6040"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156144","number":156144,"mergeCommit":{"message":"[Fleet] [Message Signing] Respond with a generic error when rotate key pair fails (#156144)\n\n## Summary\r\n\r\nResponds with a generic error message for the rotate key pair API,\r\ninstead of a trace message of where the error was generated.\r\n\r\nWe log the detailed errors and this is to avoid a chance of any\r\nsensitive data (key generation details) being exposed through the API\r\nresponse.\r\n\r\nfollow up of /pull/155864\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"13486f50deb6070f4e9ab00de63827caf0ed6040"}}]}] BACKPORT--> Co-authored-by: Ashokaditya <1849116+ashokaditya@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Responds with a generic error message for the rotate key pair API, instead of a trace message of where the error was generated.
We log the detailed errors and this is to avoid a chance of any sensitive data (key generation details) being exposed through the API response.
follow up of /pull/155864
Checklist