-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enterprise Search][Behavioral Analytics] Set limit on 10k results for explore tables #156237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yansavitski
commented
Apr 30, 2023
- ✔️ For Explorer page set max items to 10k to prevent pagination and load issues
- ✔️ Indicate limit results according guidelines
yansavitski
added
release_note:skip
Skip the PR/issue when compiling release notes
backport:skip
This commit does not require backporting
Team:EnterpriseSearch
v8.8.0
labels
Apr 30, 2023
yansavitski
force-pushed
the
ba-limit-explore-results
branch
4 times, most recently
from
May 1, 2023 16:40
4874faf
to
2fe5251
Compare
...lytics_collection_view/analytics_collection_explorer/analytics_collection_explorer_table.tsx
Outdated
Show resolved
Hide resolved
yansavitski
force-pushed
the
ba-limit-explore-results
branch
from
May 2, 2023 09:22
2fe5251
to
9d4554a
Compare
yansavitski
force-pushed
the
ba-limit-explore-results
branch
from
May 2, 2023 09:30
9d4554a
to
bcbd57d
Compare
joemcelroy
approved these changes
May 2, 2023
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
yansavitski
added a commit
to yansavitski/kibana
that referenced
this pull request
May 8, 2023
…r explore tables (elastic#156237) - ✔️ For Explorer page set max items to 10k to prevent pagination and load issues - ✔️ Indicate limit results according guidelines <img width="958" alt="image" src="https://user-images.githubusercontent.com/17390745/235352939-0291eb86-9743-4558-b146-2e22de07e0c8.png"> (cherry picked from commit 2ff49bf)
yansavitski
added a commit
that referenced
this pull request
May 8, 2023
…lts for explore tables (#156237) (#156977) # Backport This will backport the following commits from `main` to `8.8`: - [[Enterprise Search][Behavioral Analytics] Set limit on 10k results for explore tables (#156237)](#156237) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yan Savitski","email":"yan.savitski@elastic.co"},"sourceCommit":{"committedDate":"2023-05-02T10:30:34Z","message":"[Enterprise Search][Behavioral Analytics] Set limit on 10k results for explore tables (#156237)\n\n- ✔️ For Explorer page set max items to 10k to prevent pagination and\r\nload issues\r\n- ✔️ Indicate limit results according guidelines\r\n<img width=\"958\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/17390745/235352939-0291eb86-9743-4558-b146-2e22de07e0c8.png\">","sha":"2ff49bf9f09368a2e1fd13748532d70a829b858f","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","Team:EnterpriseSearch","v8.8.0","v8.9.0"],"number":156237,"url":"https://github.com/elastic/kibana/pull/156237","mergeCommit":{"message":"[Enterprise Search][Behavioral Analytics] Set limit on 10k results for explore tables (#156237)\n\n- ✔️ For Explorer page set max items to 10k to prevent pagination and\r\nload issues\r\n- ✔️ Indicate limit results according guidelines\r\n<img width=\"958\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/17390745/235352939-0291eb86-9743-4558-b146-2e22de07e0c8.png\">","sha":"2ff49bf9f09368a2e1fd13748532d70a829b858f"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156237","number":156237,"mergeCommit":{"message":"[Enterprise Search][Behavioral Analytics] Set limit on 10k results for explore tables (#156237)\n\n- ✔️ For Explorer page set max items to 10k to prevent pagination and\r\nload issues\r\n- ✔️ Indicate limit results according guidelines\r\n<img width=\"958\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/17390745/235352939-0291eb86-9743-4558-b146-2e22de07e0c8.png\">","sha":"2ff49bf9f09368a2e1fd13748532d70a829b858f"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
Team:EnterpriseSearch
v8.8.0
v8.9.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.