Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search][Behavioral Analytics] Set limit on 10k results for explore tables #156237

Merged
merged 1 commit into from
May 2, 2023

Conversation

yansavitski
Copy link
Contributor

  • ✔️ For Explorer page set max items to 10k to prevent pagination and load issues
  • ✔️ Indicate limit results according guidelines

image

@yansavitski yansavitski added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:EnterpriseSearch v8.8.0 labels Apr 30, 2023
@yansavitski yansavitski requested review from joemcelroy and a team April 30, 2023 12:27
@yansavitski yansavitski force-pushed the ba-limit-explore-results branch 4 times, most recently from 4874faf to 2fe5251 Compare May 1, 2023 16:40
@yansavitski yansavitski merged commit 2ff49bf into elastic:main May 2, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.3MB 2.3MB +334.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 479 482 +3
total +5

History

  • 💚 Build #124543 succeeded 2fe5251b0f3ec0a1613ca33d0fdd9e07bc90f3d8
  • 💛 Build #124482 was flaky 4874faf219057ad576bef57b21b338ae6c31304a
  • 💚 Build #124461 succeeded b671ea3544e5a985582dab82502c5acb1db64901

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yansavitski
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

yansavitski added a commit to yansavitski/kibana that referenced this pull request May 8, 2023
…r explore tables (elastic#156237)

- ✔️ For Explorer page set max items to 10k to prevent pagination and
load issues
- ✔️ Indicate limit results according guidelines
<img width="958" alt="image"
src="https://user-images.githubusercontent.com/17390745/235352939-0291eb86-9743-4558-b146-2e22de07e0c8.png">

(cherry picked from commit 2ff49bf)
yansavitski added a commit that referenced this pull request May 8, 2023
…lts for explore tables (#156237) (#156977)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Enterprise Search][Behavioral Analytics] Set limit on 10k results
for explore tables
(#156237)](#156237)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Yan
Savitski","email":"yan.savitski@elastic.co"},"sourceCommit":{"committedDate":"2023-05-02T10:30:34Z","message":"[Enterprise
Search][Behavioral Analytics] Set limit on 10k results for explore
tables (#156237)\n\n- ✔️ For Explorer page set max items to 10k to
prevent pagination and\r\nload issues\r\n- ✔️ Indicate limit results
according guidelines\r\n<img width=\"958\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/17390745/235352939-0291eb86-9743-4558-b146-2e22de07e0c8.png\">","sha":"2ff49bf9f09368a2e1fd13748532d70a829b858f","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","Team:EnterpriseSearch","v8.8.0","v8.9.0"],"number":156237,"url":"https://github.com/elastic/kibana/pull/156237","mergeCommit":{"message":"[Enterprise
Search][Behavioral Analytics] Set limit on 10k results for explore
tables (#156237)\n\n- ✔️ For Explorer page set max items to 10k to
prevent pagination and\r\nload issues\r\n- ✔️ Indicate limit results
according guidelines\r\n<img width=\"958\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/17390745/235352939-0291eb86-9743-4558-b146-2e22de07e0c8.png\">","sha":"2ff49bf9f09368a2e1fd13748532d70a829b858f"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156237","number":156237,"mergeCommit":{"message":"[Enterprise
Search][Behavioral Analytics] Set limit on 10k results for explore
tables (#156237)\n\n- ✔️ For Explorer page set max items to 10k to
prevent pagination and\r\nload issues\r\n- ✔️ Indicate limit results
according guidelines\r\n<img width=\"958\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/17390745/235352939-0291eb86-9743-4558-b146-2e22de07e0c8.png\">","sha":"2ff49bf9f09368a2e1fd13748532d70a829b858f"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants