Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slo): Add burn rate rule documentation link #156283

Merged
merged 1 commit into from
May 1, 2023

Conversation

kdelemme
Copy link
Contributor

@kdelemme kdelemme commented May 1, 2023

Resolves #147860

Summary

This PR adds the slo burn rate rule documentation link in the rule UI.

The link was taken from here: elastic/observability-docs#2461 (comment)

image

@kdelemme kdelemme self-assigned this May 1, 2023
@kdelemme kdelemme added the v8.8.0 label May 1, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kdelemme kdelemme added backport release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport v8.8.0 labels May 1, 2023
@kdelemme kdelemme marked this pull request as ready for review May 1, 2023 17:13
@kdelemme kdelemme requested review from a team as code owners May 1, 2023 17:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@kdelemme kdelemme force-pushed the feat/slo-burn-rate-doc-link branch from da3262c to 6cf226a Compare May 1, 2023 17:49
@kdelemme kdelemme removed the request for review from a team May 1, 2023 17:49
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #39 / discover feature controls discover feature controls security no discover privileges "before all" hook for "shows 403"

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 56.2KB 56.2KB +65.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 479 482 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kdelemme

Copy link
Contributor

@CoenWarmer CoenWarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kdelemme kdelemme added the v8.9.0 label May 1, 2023
@kdelemme kdelemme merged commit 5ef0df5 into elastic:main May 1, 2023
@kdelemme kdelemme deleted the feat/slo-burn-rate-doc-link branch May 1, 2023 22:13
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 1, 2023
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 1, 2023
…6313)

# Backport

This will backport the following commits from `main` to `8.8`:
- [feat(slo): Add burn rate rule documentation link
(#156283)](#156283)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kevin
Delemme","email":"kevin.delemme@elastic.co"},"sourceCommit":{"committedDate":"2023-05-01T22:13:14Z","message":"feat(slo):
Add burn rate rule documentation link
(#156283)","sha":"5ef0df58008aa4a1eaddc3654232d910a3dc7a79","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:
Actionable
Observability","backport:prev-minor","v8.9.0"],"number":156283,"url":"https://github.com/elastic/kibana/pull/156283","mergeCommit":{"message":"feat(slo):
Add burn rate rule documentation link
(#156283)","sha":"5ef0df58008aa4a1eaddc3654232d910a3dc7a79"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156283","number":156283,"mergeCommit":{"message":"feat(slo):
Add burn rate rule documentation link
(#156283)","sha":"5ef0df58008aa4a1eaddc3654232d910a3dc7a79"}}]}]
BACKPORT-->

Co-authored-by: Kevin Delemme <kevin.delemme@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SLO] Create documentation for SLO burn rate rule
6 participants