[RAM][Maintenance Window][8.8] Remove Extra Commas and Disable Fetch If No License #156296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiaweiWu
added
bug
|
Pinging @elastic/response-ops (Team:ResponseOps) |
JiaweiWu
changed the title
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 3, 2023
…If No License (elastic#156296) ## Summary Remove some extra commas for the maintenance window no license prompt  Also, disable fetch if the user does not have the correct license type, this gets rid of the unnecessary error popover since the find maintenance window API will reject these requests. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit f7881f6)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 3, 2023
…Fetch If No License (#156296) (#156573) # Backport This will backport the following commits from `main` to `8.8`: - [[RAM][Maintenance Window][8.8] Remove Extra Commas and Disable Fetch If No License (#156296)](#156296) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jiawei Wu","email":"74562234+JiaweiWu@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-03T15:35:56Z","message":"[RAM][Maintenance Window][8.8] Remove Extra Commas and Disable Fetch If No License (#156296)\n\n## Summary\r\n\r\nRemove some extra commas for the maintenance window no license prompt \r\n\r\n\r\n\r\n\r\nAlso, disable fetch if the user does not have the correct license type,\r\nthis gets rid of the unnecessary error popover since the find\r\nmaintenance window API will reject these requests.\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"f7881f6658f1d7c65280482c047785ba5ea5c302","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","backport","release_note:skip","impact:low","Team:ResponseOps","Feature:Alerting/RulesManagement","v8.8.0","v8.9.0"],"number":156296,"url":"https://github.com/elastic/kibana/pull/156296","mergeCommit":{"message":"[RAM][Maintenance Window][8.8] Remove Extra Commas and Disable Fetch If No License (#156296)\n\n## Summary\r\n\r\nRemove some extra commas for the maintenance window no license prompt \r\n\r\n\r\n\r\n\r\nAlso, disable fetch if the user does not have the correct license type,\r\nthis gets rid of the unnecessary error popover since the find\r\nmaintenance window API will reject these requests.\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"f7881f6658f1d7c65280482c047785ba5ea5c302"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156296","number":156296,"mergeCommit":{"message":"[RAM][Maintenance Window][8.8] Remove Extra Commas and Disable Fetch If No License (#156296)\n\n## Summary\r\n\r\nRemove some extra commas for the maintenance window no license prompt \r\n\r\n\r\n\r\n\r\nAlso, disable fetch if the user does not have the correct license type,\r\nthis gets rid of the unnecessary error popover since the find\r\nmaintenance window API will reject these requests.\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"f7881f6658f1d7c65280482c047785ba5ea5c302"}}]}] BACKPORT--> Co-authored-by: Jiawei Wu <74562234+JiaweiWu@users.noreply.github.com>
\r\n\r\nAlso){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove some extra commas for the maintenance window no license prompt
Also, disable fetch if the user does not have the correct license type, this gets rid of the unnecessary error popover since the find maintenance window API will reject these requests.
Checklist