Fix throughput chart on APM alert details page #156348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
maryam-saeidi
added
release_note:skip
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
maryam-saeidi
added
the
backport:prev-minor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
kdelemme
approved these changes
May 2, 2023
|
Pinging @elastic/apm-ui (Team:APM) |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 2, 2023
Fixes elastic#154802 ## Summary Fix the Y-axis label and tooltip: <img src="https://user-images.githubusercontent.com/12370520/235647500-5efb80c4-5c93-47b3-bd69-6518ae330a4b.png" width="500" /> ## 🧪 How to test - Create an APM Latency threshold alert - Go to the alert details page and check the throughput chart for the correct label and tooltip (cherry picked from commit c271cbb)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 2, 2023
# Backport This will backport the following commits from `main` to `8.8`: - [Fix throughput chart on APM alert details page (#156348)](#156348) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maryam Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2023-05-02T13:52:46Z","message":"Fix throughput chart on APM alert details page (#156348)\n\nFixes #154802\r\n\r\n## Summary\r\n\r\nFix the Y-axis label and tooltip:\r\n\r\n<img\r\nsrc=\"https://user-images.githubusercontent.com/12370520/235647500-5efb80c4-5c93-47b3-bd69-6518ae330a4b.png\"\r\nwidth=\"500\" />\r\n\r\n## 🧪 How to test\r\n- Create an APM Latency threshold alert\r\n- Go to the alert details page and check the throughput chart for the\r\ncorrect label and tooltip","sha":"c271cbb739d4c8fef2eaa599e27f37ba05c0a6ee","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:APM","release_note:skip","Team: Actionable Observability","backport:prev-minor","v8.9.0"],"number":156348,"url":"https://github.com/elastic/kibana/pull/156348","mergeCommit":{"message":"Fix throughput chart on APM alert details page (#156348)\n\nFixes #154802\r\n\r\n## Summary\r\n\r\nFix the Y-axis label and tooltip:\r\n\r\n<img\r\nsrc=\"https://user-images.githubusercontent.com/12370520/235647500-5efb80c4-5c93-47b3-bd69-6518ae330a4b.png\"\r\nwidth=\"500\" />\r\n\r\n## 🧪 How to test\r\n- Create an APM Latency threshold alert\r\n- Go to the alert details page and check the throughput chart for the\r\ncorrect label and tooltip","sha":"c271cbb739d4c8fef2eaa599e27f37ba05c0a6ee"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156348","number":156348,"mergeCommit":{"message":"Fix throughput chart on APM alert details page (#156348)\n\nFixes #154802\r\n\r\n## Summary\r\n\r\nFix the Y-axis label and tooltip:\r\n\r\n<img\r\nsrc=\"https://user-images.githubusercontent.com/12370520/235647500-5efb80c4-5c93-47b3-bd69-6518ae330a4b.png\"\r\nwidth=\"500\" />\r\n\r\n## 🧪 How to test\r\n- Create an APM Latency threshold alert\r\n- Go to the alert details page and check the throughput chart for the\r\ncorrect label and tooltip","sha":"c271cbb739d4c8fef2eaa599e27f37ba05c0a6ee"}}]}] BACKPORT--> Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
![https://user-images.githubusercontent.com/12370520/235647500-5efb80c4-5c93-47b3-bd69-6518ae330a4b.png\"\r\nwidth=\"500\](https://user-images.githubusercontent.com/12370520/235647500-5efb80c4-5c93-47b3-bd69-6518ae330a4b.png\"\r\nwidth=\"500\){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154802
Fixes #153137
Summary
Fix the Y-axis label and tooltip:
🧪 How to test