[Infrastructure UI] Fix Lens charts for APM hosts #156372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
crespocarlos
changed the title
crespocarlos
added
Feature:Metrics UI
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 2, 2023
## Summary After the implementation of the new API and host limit, all charts now load only after the table is loaded. This PR changes the filters the page currently passes to Lens, to pass only a list of host names, the same way Alerts and Logs tabs do it. This also fixes a problem where filters remove documents containing metrics data. <img width="772" alt="image" src="https://user-images.githubusercontent.com/2767137/235683301-35709698-49c2-4871-a724-2d2ca662f3f2.png"> <img width="772" alt="image" src="https://user-images.githubusercontent.com/2767137/235683956-f7170213-afbd-400d-a190-a02087831af1.png"> ### How to test - Connect your local kibana to an oblt cluster - Go to Hosts view - Filter by `service.name: "opbeans-java"` (cherry picked from commit e980427)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 2, 2023
…56390) # Backport This will backport the following commits from `main` to `8.8`: - [[Infrastructure UI] Fix Lens charts for APM hosts (#156372)](#156372) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Carlos Crespo","email":"crespocarlos@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-02T13:56:06Z","message":"[Infrastructure UI] Fix Lens charts for APM hosts (#156372)\n\n## Summary\r\n\r\nAfter the implementation of the new API and host limit, all charts now\r\nload only after the table is loaded. This PR changes the filters the\r\npage currently passes to Lens, to pass only a list of host names, the\r\nsame way Alerts and Logs tabs do it.\r\n\r\nThis also fixes a problem where filters remove documents containing\r\nmetrics data.\r\n\r\n\r\n<img width=\"772\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/2767137/235683301-35709698-49c2-4871-a724-2d2ca662f3f2.png\">\r\n\r\n<img width=\"772\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/2767137/235683956-f7170213-afbd-400d-a190-a02087831af1.png\">\r\n\r\n\r\n\r\n\r\n### How to test\r\n\r\n- Connect your local kibana to an oblt cluster\r\n- Go to Hosts view\r\n- Filter by `service.name: \"opbeans-java\"`","sha":"e9804277b20320e37dde3ceaaa6f9ae1b66e3b23","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Metrics UI","Team:Infra Monitoring UI","release_note:skip","backport:prev-minor","Feature:ObsHosts","v8.9.0"],"number":156372,"url":"#156372 UI] Fix Lens charts for APM hosts (#156372)\n\n## Summary\r\n\r\nAfter the implementation of the new API and host limit, all charts now\r\nload only after the table is loaded. This PR changes the filters the\r\npage currently passes to Lens, to pass only a list of host names, the\r\nsame way Alerts and Logs tabs do it.\r\n\r\nThis also fixes a problem where filters remove documents containing\r\nmetrics data.\r\n\r\n\r\n<img width=\"772\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/2767137/235683301-35709698-49c2-4871-a724-2d2ca662f3f2.png\">\r\n\r\n<img width=\"772\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/2767137/235683956-f7170213-afbd-400d-a190-a02087831af1.png\">\r\n\r\n\r\n\r\n\r\n### How to test\r\n\r\n- Connect your local kibana to an oblt cluster\r\n- Go to Hosts view\r\n- Filter by `service.name: \"opbeans-java\"`","sha":"e9804277b20320e37dde3ceaaa6f9ae1b66e3b23"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"#156372 UI] Fix Lens charts for APM hosts (#156372)\n\n## Summary\r\n\r\nAfter the implementation of the new API and host limit, all charts now\r\nload only after the table is loaded. This PR changes the filters the\r\npage currently passes to Lens, to pass only a list of host names, the\r\nsame way Alerts and Logs tabs do it.\r\n\r\nThis also fixes a problem where filters remove documents containing\r\nmetrics data.\r\n\r\n\r\n<img width=\"772\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/2767137/235683301-35709698-49c2-4871-a724-2d2ca662f3f2.png\">\r\n\r\n<img width=\"772\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/2767137/235683956-f7170213-afbd-400d-a190-a02087831af1.png\">\r\n\r\n\r\n\r\n\r\n### How to test\r\n\r\n- Connect your local kibana to an oblt cluster\r\n- Go to Hosts view\r\n- Filter by `service.name: \"opbeans-java\"`","sha":"e9804277b20320e37dde3ceaaa6f9ae1b66e3b23"}}]}] BACKPORT--> Co-authored-by: Carlos Crespo <crespocarlos@users.noreply.github.com>
![https://user-images.githubusercontent.com/2767137/235683301-35709698-49c2-4871-a724-2d2ca662f3f2.png\">\r\n\r\n<img](https://user-images.githubusercontent.com/2767137/235683301-35709698-49c2-4871-a724-2d2ca662f3f2.png\">\r\n\r\n<img){kind=link}
![https://user-images.githubusercontent.com/2767137/235683956-f7170213-afbd-400d-a190-a02087831af1.png\">\r\n\r\n\r\n\r\n\r\n###](https://user-images.githubusercontent.com/2767137/235683956-f7170213-afbd-400d-a190-a02087831af1.png\">\r\n\r\n\r\n\r\n\r\n###){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #151768
Summary
After the implementation of the new API and host limit, all charts now load only after the table is loaded. This PR changes the filters the page currently passes to Lens, to pass only a list of host names, the same way Alerts and Logs tabs do it.
This also fixes a problem where filters remove documents containing metrics data.
How to test
service.name: "opbeans-java"