-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Removes messageSigningService api definition from openApi spec #156376
Merged
dasansol92
merged 1 commit into
elastic:main
from
dasansol92:feat/olm-remove_message_signing_API_from_openAPI_spec-6541
May 2, 2023
Merged
[Fleet] Removes messageSigningService api definition from openApi spec #156376
dasansol92
merged 1 commit into
elastic:main
from
dasansol92:feat/olm-remove_message_signing_API_from_openAPI_spec-6541
May 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dates error message when no acknowledge param
dasansol92
added
release_note:skip
Skip the PR/issue when compiling release notes
Team:Defend Workflows
“EDR Workflows” sub-team of Security Solution
v8.8.0
v8.9.0
Team:Fleet
Team label for Observability Data Collection Fleet team
labels
May 2, 2023
Pinging @elastic/fleet (Team:Fleet) |
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
dasansol92
requested review from
a team,
joeypoon,
tomsonpl and
ashokaditya
and removed request for
a team and
tomsonpl
May 2, 2023 13:52
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
patrykkopycinski
approved these changes
May 2, 2023
ashokaditya
approved these changes
May 2, 2023
parkiino
approved these changes
May 2, 2023
juliaElastic
approved these changes
May 2, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 2, 2023
elastic#156376) ## Summary - Removes message signing service api definition from openAPI spec. - Updates warning message when `acknowledge` param is missing or set to false. (cherry picked from commit b961399)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 2, 2023
…pi spec (#156376) (#156401) # Backport This will backport the following commits from `main` to `8.8`: - [[Fleet] Removes messageSigningService api definition from openApi spec (#156376)](#156376) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"David Sánchez","email":"david.sanchezsoler@elastic.co"},"sourceCommit":{"committedDate":"2023-05-02T14:28:11Z","message":"[Fleet] Removes messageSigningService api definition from openApi spec (#156376)\n\n## Summary\r\n\r\n- Removes message signing service api definition from openAPI spec.\r\n- Updates warning message when `acknowledge` param is missing or set to\r\nfalse.","sha":"b9613994b11ce23bf511f097d3f4b2a974bfce93","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","Team:Defend Workflows","v8.8.0","v8.9.0"],"number":156376,"url":"#156376 Removes messageSigningService api definition from openApi spec (#156376)\n\n## Summary\r\n\r\n- Removes message signing service api definition from openAPI spec.\r\n- Updates warning message when `acknowledge` param is missing or set to\r\nfalse.","sha":"b9613994b11ce23bf511f097d3f4b2a974bfce93"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"#156376 Removes messageSigningService api definition from openApi spec (#156376)\n\n## Summary\r\n\r\n- Removes message signing service api definition from openAPI spec.\r\n- Updates warning message when `acknowledge` param is missing or set to\r\nfalse.","sha":"b9613994b11ce23bf511f097d3f4b2a974bfce93"}}]}] BACKPORT--> Co-authored-by: David Sánchez <david.sanchezsoler@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:Defend Workflows
“EDR Workflows” sub-team of Security Solution
Team:Fleet
Team label for Observability Data Collection Fleet team
v8.8.0
v8.9.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
acknowledge
param is missing or set to false.