Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unable to create roles under Stack Management #156381

Merged
merged 5 commits into from
May 2, 2023
Merged

Fix unable to create roles under Stack Management #156381

merged 5 commits into from
May 2, 2023

Conversation

thomheymann
Copy link
Contributor

@thomheymann thomheymann commented May 2, 2023 •
edited by kibanamachine
Loading

Resolves #156249

@thomheymann thomheymann added backport Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.8.0 v8.9.0 labels May 2, 2023
@thomheymann thomheymann marked this pull request as ready for review May 2, 2023 13:24
@thomheymann thomheymann requested a review from a team as a code owner May 2, 2023 13:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@kc13greiner kc13greiner self-requested a review May 2, 2023 18:02
kc13greiner
kc13greiner approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@legrego legrego merged commit de0498d into elastic:main May 2, 2023
@kibanamachine kibanamachine mentioned this pull request May 2, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 2, 2023
@thomheymann
Fix unable to create roles under Stack Management (elastic#156381)
88fb96a 
Resolves elastic#156249

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit de0498d)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 2, 2023
@kibanamachine @thomheymann
[8.8] Fix unable to create roles under Stack Management (#156381) (#1…
29af54c 
…56440)

# Backport

This will backport the following commits from `main` to `8.8`:
- [Fix unable to create roles under Stack Management
(#156381)](#156381)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Thom
Heymann","email":"190132+thomheymann@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-02T19:46:37Z","message":"Fix
unable to create roles under Stack Management (#156381)\n\nResolves
#156249\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"de0498decb0992a6b20a4158aeae0d3bd39278b3","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","Team:Security","v8.8.0","v8.9.0"],"number":156381,"url":"#156381
unable to create roles under Stack Management (#156381)\n\nResolves
#156249\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"de0498decb0992a6b20a4158aeae0d3bd39278b3"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"#156381
unable to create roles under Stack Management (#156381)\n\nResolves
#156249\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"de0498decb0992a6b20a4158aeae0d3bd39278b3"}}]}]
BACKPORT-->

Co-authored-by: Thom Heymann <190132+thomheymann@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kc13greiner kc13greiner kc13greiner approved these changes

Assignees
No one assigned
Labels
backport Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security] Unable to create roles under Stack Management>Roles.
6 participants
@thomheymann @elasticmachine @kibana-ci @kibanamachine @kc13greiner @legrego