Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Rename ELSER model id #156382

Merged
merged 4 commits into from
May 2, 2023
Merged

[ML] Rename ELSER model id #156382

merged 4 commits into from
May 2, 2023

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented May 2, 2023 •
edited by kibanamachine
Loading

Summary

  • Renames ELSER model id
  • Adds a technical preview badge

image

@darnautov darnautov added :ml release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) v8.8.0 v8.9.0 labels May 2, 2023
@darnautov darnautov self-assigned this May 2, 2023
@darnautov darnautov requested a review from a team as a code owner May 2, 2023 13:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested (didn't download) and LGTM

@darnautov darnautov enabled auto-merge (squash) May 2, 2023 15:38
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.3MB 2.3MB +18.0B
ml 3.4MB 3.4MB +346.0B
total +364.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 479 482 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov merged commit 3cd3549 into elastic:main May 2, 2023
@kibanamachine kibanamachine mentioned this pull request May 2, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 2, 2023
@darnautov
[ML] Rename ELSER model id (elastic#156382)
c8d319f 
(cherry picked from commit 3cd3549)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 2, 2023
@kibanamachine @darnautov
[8.8] [ML] Rename ELSER model id (#156382) (#156420)
d49bcea 
# Backport

This will backport the following commits from `main` to `8.8`:
- [[ML] Rename ELSER model id
(#156382)](#156382)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"dmitrii.arnautov@elastic.co"},"sourceCommit":{"committedDate":"2023-05-02T16:09:46Z","message":"[ML]
Rename ELSER model id
(#156382)","sha":"3cd35494aba67aaae6c3021d6a140ee7feb18b4e","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","Team:ML","v8.8.0","v8.9.0"],"number":156382,"url":"https://github.com/elastic/kibana/pull/156382","mergeCommit":{"message":"[ML]
Rename ELSER model id
(#156382)","sha":"3cd35494aba67aaae6c3021d6a140ee7feb18b4e"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156382","number":156382,"mergeCommit":{"message":"[ML]
Rename ELSER model id
(#156382)","sha":"3cd35494aba67aaae6c3021d6a140ee7feb18b4e"}}]}]
BACKPORT-->

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
@darnautov darnautov deleted the ml-rename-elser-model-id branch May 3, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@dimkots dimkots dimkots approved these changes

Assignees

@darnautov darnautov

Labels
:ml release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@darnautov @elasticmachine @kibana-ci @kibanamachine @dimkots @peteharverson