Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.8] [Security Solution] [Fix] Alert Page Controls do not take Alert Table "Additional Filters" into account. (#155861) #156388

Merged
merged 1 commit into from
May 2, 2023
Merged

[8.8] [Security Solution] [Fix] Alert Page Controls do not take Alert Table "Additional Filters" into account. (#155861) #156388

merged 1 commit into from
May 2, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.8:

Questions ?

Please refer to the Backport tool documentation

@logeekal
[Security Solution] [Fix] Alert Page Controls do not take Alert Table…
bcd56aa 
… "Additional Filters" into account. (elastic#155861)

## Summary

This PR handles : [Security Solution] New alert filters are not taking
into consideration alert table filters elastic#155173 and elastic#156252

Currently, Alert Page Controls do not take Alert Table Checkboxes (
Building block + Threat indicator alerts only ) into account. This PR
enables the effect of Alert Table Checkboxes on Alert Page controls

| Before | After |
|--|--|
| <video
src="https://user-images.githubusercontent.com/7485038/234568673-b05ffc32-09bc-4378-aecb-bb64dbc5cbb6.mov"
/> | <video
src="https://user-images.githubusercontent.com/7485038/234562759-6309d6a0-f7db-48fd-bd9e-62788a1c89fe.mov"/>
|

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios.

(cherry picked from commit aeded80)
@kibanamachine kibanamachine enabled auto-merge (squash) May 2, 2023 13:54
@kibanamachine kibanamachine mentioned this pull request May 2, 2023
Merged
1 task
@kibanamachine kibanamachine merged commit 2cd6d1b into elastic:8.8 May 2, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #12 / spaces api without security get can access default from within the space_1 space "before all" hook for "should return 200 when referencing the space_1 space explicitly in the URL"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.1MB 9.1MB +33.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @logeekal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@logeekal logeekal

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @kibana-ci @logeekal