Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution] Restore lens table columns when Reset group by field clicked. #156393

Merged
merged 4 commits into from
May 2, 2023
Merged

[SecuritySolution] Restore lens table columns when Reset group by field clicked. #156393

merged 4 commits into from
May 2, 2023

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented May 2, 2023 •
edited by kibanamachine
Loading

Summary

issue: #155859
Steps to reproduce: Please find the issue above.

Reset group by field action should:

  1. Revert Group by and Group by top to default fields kibana.alert.rule.name and host.name
  2. Unhide all the columns in the table.

Checklist

Delete any items that are not applicable to this PR.

@angorayc angorayc self-assigned this May 2, 2023
@angorayc angorayc added bug Fixes for quality problems that affect the customer experience Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.8.0 Feature:Lens Charts Security Solution Lens Charts feature labels May 2, 2023
@angorayc angorayc changed the title Restore lens table columns when Reset group by field clicked. [SecuritySolution] Restore lens table columns when Reset group by field clicked. May 2, 2023
@angorayc angorayc mentioned this pull request May 2, 2023
Closed
@angorayc angorayc marked this pull request as ready for review May 2, 2023 15:01
@angorayc angorayc requested review from a team as code owners May 2, 2023 15:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@angorayc angorayc added the release_note:skip Skip the PR/issue when compiling release notes label May 2, 2023
christineweng
christineweng reviewed May 2, 2023
View reviewed changes
Copy link
Contributor

@christineweng christineweng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Desk tested and LGTM! Just a small comment about a typo in LensDataTableAttributes.

x-pack/plugins/security_solution/public/common/components/visualization_actions/types.ts Outdated Show resolved Hide resolved
@angorayc angorayc enabled auto-merge (squash) May 2, 2023 20:20
@angorayc angorayc merged commit db02784 into elastic:main May 2, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #3 / timeline flyout button the (+) button popover menu owns focus

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.1MB 9.1MB +4.3KB
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @angorayc

@kibanamachine kibanamachine mentioned this pull request May 2, 2023
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 2, 2023
@angorayc
[SecuritySolution] Restore lens table columns when Reset group by fie…
b67ed39 
…ld clicked. (elastic#156393)

## Summary

issue: elastic#155859
Steps to reproduce: Please find the issue above.

`Reset group by field` action should:
1. Revert `Group by` and `Group by top` to default fields
`kibana.alert.rule.name` and `host.name`
2. Unhide all the columns in the table.

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit db02784)
kibanamachine added a commit that referenced this pull request May 2, 2023
@kibanamachine @angorayc
[8.8] [SecuritySolution] Restore lens table columns when Reset group …
44753b2 
…by field clicked. (#156393) (#156454)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[SecuritySolution] Restore lens table columns when Reset group by
field clicked. (#156393)](#156393)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Angela
Chuang","email":"6295984+angorayc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-02T22:02:12Z","message":"[SecuritySolution]
Restore lens table columns when Reset group by field clicked.
(#156393)\n\n## Summary\r\n\r\nissue:
#155859 to reproduce:
Please find the issue above.\r\n\r\n`Reset group by field` action
should:\r\n1. Revert `Group by` and `Group by top` to default
fields\r\n`kibana.alert.rule.name` and `host.name`\r\n2. Unhide all the
columns in the table.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items
that are not applicable to this PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"db02784f98c6c41cbb0a0ccbc4895d67b698c4aa","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Explore","v8.8.0","Feature:Lens
Charts","v8.9.0"],"number":156393,"url":"#156393
Restore lens table columns when Reset group by field clicked.
(#156393)\n\n## Summary\r\n\r\nissue:
#155859 to reproduce:
Please find the issue above.\r\n\r\n`Reset group by field` action
should:\r\n1. Revert `Group by` and `Group by top` to default
fields\r\n`kibana.alert.rule.name` and `host.name`\r\n2. Unhide all the
columns in the table.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items
that are not applicable to this PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"db02784f98c6c41cbb0a0ccbc4895d67b698c4aa"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"#156393
Restore lens table columns when Reset group by field clicked.
(#156393)\n\n## Summary\r\n\r\nissue:
#155859 to reproduce:
Please find the issue above.\r\n\r\n`Reset group by field` action
should:\r\n1. Revert `Group by` and `Group by top` to default
fields\r\n`kibana.alert.rule.name` and `host.name`\r\n2. Unhide all the
columns in the table.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items
that are not applicable to this PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"db02784f98c6c41cbb0a0ccbc4895d67b698c4aa"}}]}]
BACKPORT-->

Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christineweng christineweng christineweng approved these changes

Assignees

@angorayc angorayc

Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Charts Security Solution Lens Charts feature release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@angorayc @elasticmachine @kibana-ci @kibanamachine @christineweng