Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Fixes typo in edit rules step #156397

Merged
merged 1 commit into from
May 2, 2023

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented May 2, 2023

Summary

Fixes a little typo introduced with the rule snooze functionality when editing a rule.

Before:
Screenshot 2023-05-02 at 16 12 14

After:
Screenshot 2023-05-02 at 16 21 43

@MadameSheema MadameSheema added release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team v8.8.0 v8.9.0 labels May 2, 2023
@MadameSheema MadameSheema self-assigned this May 2, 2023
@MadameSheema MadameSheema requested a review from a team as a code owner May 2, 2023 14:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

Copy link
Contributor

@banderror banderror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MadameSheema ❤️

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @MadameSheema

@MadameSheema MadameSheema merged commit ee9d782 into elastic:main May 2, 2023
@MadameSheema MadameSheema deleted the edit-rule-snooze-typo branch May 2, 2023 15:57
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 2, 2023
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@MadameSheema
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

MadameSheema added a commit to MadameSheema/kibana that referenced this pull request May 2, 2023
kibanamachine added a commit that referenced this pull request May 2, 2023
…56417)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solution] Fixes typo in edit rules step
(#156397)](#156397)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gloria
Hornero","email":"gloria.hornero@elastic.co"},"sourceCommit":{"committedDate":"2023-05-02T15:57:16Z","message":"[Security
Solution] Fixes typo in edit rules step
(#156397)","sha":"ee9d782793971cb8812c6cad3e2051c23836fb6c","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection
Rules","v8.8.0","v8.9.0"],"number":156397,"url":"#156397
Solution] Fixes typo in edit rules step
(#156397)","sha":"ee9d782793971cb8812c6cad3e2051c23836fb6c"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"#156397
Solution] Fixes typo in edit rules step
(#156397)","sha":"ee9d782793971cb8812c6cad3e2051c23836fb6c"}}]}]
BACKPORT-->

Co-authored-by: Gloria Hornero <gloria.hornero@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants