-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Fixes typo in edit rules step #156397
Conversation
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @MadameSheema ❤️
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
(cherry picked from commit ee9d782)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
(cherry picked from commit ee9d782)
…56417) # Backport This will backport the following commits from `main` to `8.8`: - [[Security Solution] Fixes typo in edit rules step (#156397)](#156397) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gloria Hornero","email":"gloria.hornero@elastic.co"},"sourceCommit":{"committedDate":"2023-05-02T15:57:16Z","message":"[Security Solution] Fixes typo in edit rules step (#156397)","sha":"ee9d782793971cb8812c6cad3e2051c23836fb6c","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rules","v8.8.0","v8.9.0"],"number":156397,"url":"#156397 Solution] Fixes typo in edit rules step (#156397)","sha":"ee9d782793971cb8812c6cad3e2051c23836fb6c"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"#156397 Solution] Fixes typo in edit rules step (#156397)","sha":"ee9d782793971cb8812c6cad3e2051c23836fb6c"}}]}] BACKPORT--> Co-authored-by: Gloria Hornero <gloria.hornero@elastic.co>
Summary
Fixes a little typo introduced with the rule snooze functionality when editing a rule.
Before:
After: