Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing Chart name in Alert Trend Inspect Modal Title #156476

Merged
merged 1 commit into from
May 4, 2023
Merged

Fix missing Chart name in Alert Trend Inspect Modal Title #156476

merged 1 commit into from
May 4, 2023

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented May 3, 2023 •
edited by kibanamachine
Loading

issue: #155032

Summary

Add a title to the "inspect model".

BEFORE

AFTER

@machadoum machadoum requested a review from a team as a code owner May 3, 2023 08:20
@machadoum machadoum self-assigned this May 3, 2023
@machadoum machadoum added bug Fixes for quality problems that affect the customer experience Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.8.0 labels May 3, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@machadoum machadoum added the release_note:skip Skip the PR/issue when compiling release notes label May 3, 2023
@machadoum machadoum requested review from a team as code owners May 3, 2023 10:46
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #3 / timeline flyout button the (+) button popover menu owns focus

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.1MB 9.1MB +44.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 479 482 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

semd
semd approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

christineweng
christineweng approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@christineweng christineweng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thanks for putting in the fix!

@machadoum machadoum merged commit 0974e59 into elastic:main May 4, 2023
@kibanamachine kibanamachine mentioned this pull request May 4, 2023
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 4, 2023
@machadoum
Fix missing Chart name in Alert Trend Inspect Modal Title (elastic#15…
97ca209 
…6476)

issue: elastic#155032

## Summary

Add a title to the "inspect model".

**BEFORE**
<img width="500"
src="https://user-images.githubusercontent.com/1490444/235864517-e04b1f20-454c-4ae7-9ad2-84ffc378cb82.png">

**AFTER**
<img width="500"
src="https://user-images.githubusercontent.com/1490444/235864520-46b9b5d4-9f87-41cc-b71e-e5531a73a26a.png">

(cherry picked from commit 0974e59)
kibanamachine added a commit that referenced this pull request May 4, 2023
@kibanamachine @machadoum
[8.8] Fix missing Chart name in Alert Trend Inspect Modal Title (#156476
c559077 
) (#156647)

# Backport

This will backport the following commits from `main` to `8.8`:
- [Fix missing Chart name in Alert Trend Inspect Modal Title
(#156476)](#156476)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pablo
Machado","email":"pablo.nevesmachado@elastic.co"},"sourceCommit":{"committedDate":"2023-05-04T08:09:26Z","message":"Fix
missing Chart name in Alert Trend Inspect Modal Title
(#156476)\n\nissue:
#155032
Summary\r\n\r\nAdd a title to the \"inspect
model\".\r\n\r\n\r\n**BEFORE**\r\n<img
width=\"500\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/235864517-e04b1f20-454c-4ae7-9ad2-84ffc378cb82.png\">\r\n\r\n**AFTER**\r\n<img
width=\"500\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/235864520-46b9b5d4-9f87-41cc-b71e-e5531a73a26a.png\">","sha":"0974e5961d2774c65101211612366b4fe0ecad4e","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Explore","v8.8.0","v8.9.0"],"number":156476,"url":"#156476
missing Chart name in Alert Trend Inspect Modal Title
(#156476)\n\nissue:
#155032
Summary\r\n\r\nAdd a title to the \"inspect
model\".\r\n\r\n\r\n**BEFORE**\r\n<img
width=\"500\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/235864517-e04b1f20-454c-4ae7-9ad2-84ffc378cb82.png\">\r\n\r\n**AFTER**\r\n<img
width=\"500\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/235864520-46b9b5d4-9f87-41cc-b71e-e5531a73a26a.png\">","sha":"0974e5961d2774c65101211612366b4fe0ecad4e"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156476","number":156476,"mergeCommit":{"message":"Fix
missing Chart name in Alert Trend Inspect Modal Title
(#156476)\n\nissue:
#155032
Summary\r\n\r\nAdd a title to the \"inspect
model\".\r\n\r\n\r\n**BEFORE**\r\n<img
width=\"500\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/235864517-e04b1f20-454c-4ae7-9ad2-84ffc378cb82.png\">\r\n\r\n**AFTER**\r\n<img
width=\"500\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/235864520-46b9b5d4-9f87-41cc-b71e-e5531a73a26a.png\">","sha":"0974e5961d2774c65101211612366b4fe0ecad4e"}}]}]
BACKPORT-->

Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semd semd semd approved these changes

@christineweng christineweng christineweng approved these changes

Assignees

@machadoum machadoum

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@machadoum @elasticmachine @kibana-ci @kibanamachine @semd @christineweng