Fix Alerts table inspect modal incomplete title #156488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machadoum
added
bug
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
machadoum
force-pushed
the
siem-explore-156267
branch
from
fb6a689
to
daea4b6
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @machadoum |
XavierM
reviewed
May 3, 2023
| @@ -200,7 +201,9 @@ const ModalInspectQueryComponent = ({ closeModal, getInspectQuery }: ModalInspec | |||
| return ( | |||
| <MyEuiModal onClose={closeModal} data-test-subj="modal-inspect-euiModal"> | |||
| <EuiModalHeader> | |||
| <EuiModalHeaderTitle>{i18n.INSPECT}</EuiModalHeaderTitle> | |||
| <EuiModalHeaderTitle> | |||
| {i18n.INSPECT} {title} | |||
There was a problem hiding this comment.
I am wondering if we really the prop, can we just do that?
Suggested change
| {i18n.INSPECT} {title} | |
| {i18n.INSPECT} {ALERTS_TABLE_TITLE} |
There was a problem hiding this comment.
I am wrong here!!!, if we want to re-use this component, we need to do what you did!
XavierM
approved these changes
May 4, 2023
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 4, 2023
issue: elastic#156267 ## Summary Add a title to "Alerts Table inspect modal". **BEFORE** <img width="751" alt="Screenshot 2023-05-03 at 15 55 58" src="https://user-images.githubusercontent.com/1490444/235937998-caedf8f5-6645-440f-af1d-8618e8012d8b.png"> **AFTER** <img width="769" alt="Screenshot 2023-05-03 at 15 58 30" src="https://user-images.githubusercontent.com/1490444/235938006-6c303f9d-8b81-43d0-b536-ae23f1f5bfd1.png"> (cherry picked from commit c1d76f8)
kibanamachine
added a commit
that referenced
this pull request
May 4, 2023
) # Backport This will backport the following commits from `main` to `8.8`: - [Fix Alerts table inspect modal incomplete title (#156488)](#156488) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Pablo Machado","email":"pablo.nevesmachado@elastic.co"},"sourceCommit":{"committedDate":"2023-05-04T08:09:05Z","message":"Fix Alerts table inspect modal incomplete title (#156488)\n\nissue: https://github.com/elastic/kibana/issues/156267\r\n\r\n## Summary\r\n\r\nAdd a title to \"Alerts Table inspect modal\".\r\n\r\n**BEFORE**\r\n\r\n<img width=\"751\" alt=\"Screenshot 2023-05-03 at 15 55 58\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/235937998-caedf8f5-6645-440f-af1d-8618e8012d8b.png\">\r\n\r\n**AFTER**\r\n\r\n<img width=\"769\" alt=\"Screenshot 2023-05-03 at 15 58 30\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/235938006-6c303f9d-8b81-43d0-b536-ae23f1f5bfd1.png\">","sha":"c1d76f8b4745334ff37491914b37c80c18dbfbeb","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat Hunting","Team: SecuritySolution","Team:Threat Hunting:Explore","v8.8.0","v8.9.0"],"number":156488,"url":"https://github.com/elastic/kibana/pull/156488","mergeCommit":{"message":"Fix Alerts table inspect modal incomplete title (#156488)\n\nissue: https://github.com/elastic/kibana/issues/156267\r\n\r\n## Summary\r\n\r\nAdd a title to \"Alerts Table inspect modal\".\r\n\r\n**BEFORE**\r\n\r\n<img width=\"751\" alt=\"Screenshot 2023-05-03 at 15 55 58\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/235937998-caedf8f5-6645-440f-af1d-8618e8012d8b.png\">\r\n\r\n**AFTER**\r\n\r\n<img width=\"769\" alt=\"Screenshot 2023-05-03 at 15 58 30\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/235938006-6c303f9d-8b81-43d0-b536-ae23f1f5bfd1.png\">","sha":"c1d76f8b4745334ff37491914b37c80c18dbfbeb"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156488","number":156488,"mergeCommit":{"message":"Fix Alerts table inspect modal incomplete title (#156488)\n\nissue: https://github.com/elastic/kibana/issues/156267\r\n\r\n## Summary\r\n\r\nAdd a title to \"Alerts Table inspect modal\".\r\n\r\n**BEFORE**\r\n\r\n<img width=\"751\" alt=\"Screenshot 2023-05-03 at 15 55 58\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/235937998-caedf8f5-6645-440f-af1d-8618e8012d8b.png\">\r\n\r\n**AFTER**\r\n\r\n<img width=\"769\" alt=\"Screenshot 2023-05-03 at 15 58 30\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/235938006-6c303f9d-8b81-43d0-b536-ae23f1f5bfd1.png\">","sha":"c1d76f8b4745334ff37491914b37c80c18dbfbeb"}}]}] BACKPORT--> Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>
![https://user-images.githubusercontent.com/1490444/235937998-caedf8f5-6645-440f-af1d-8618e8012d8b.png\">\r\n\r\n**AFTER**\r\n\r\n<img](https://user-images.githubusercontent.com/1490444/235937998-caedf8f5-6645-440f-af1d-8618e8012d8b.png\">\r\n\r\n**AFTER**\r\n\r\n<img){kind=link}
![https://user-images.githubusercontent.com/1490444/235938006-6c303f9d-8b81-43d0-b536-ae23f1f5bfd1.png\">","sha":"c1d76f8b4745334ff37491914b37c80c18dbfbeb","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat](https://user-images.githubusercontent.com/1490444/235938006-6c303f9d-8b81-43d0-b536-ae23f1f5bfd1.png\">","sha":"c1d76f8b4745334ff37491914b37c80c18dbfbeb","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat){kind=link}
![https://user-images.githubusercontent.com/1490444/235938006-6c303f9d-8b81-43d0-b536-ae23f1f5bfd1.png\">","sha":"c1d76f8b4745334ff37491914b37c80c18dbfbeb"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156488","number":156488,"mergeCommit":{"message":"Fix](https://user-images.githubusercontent.com/1490444/235938006-6c303f9d-8b81-43d0-b536-ae23f1f5bfd1.png\">","sha":"c1d76f8b4745334ff37491914b37c80c18dbfbeb"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156488","number":156488,"mergeCommit":{"message":"Fix){kind=link}
![https://user-images.githubusercontent.com/1490444/235938006-6c303f9d-8b81-43d0-b536-ae23f1f5bfd1.png\">","sha":"c1d76f8b4745334ff37491914b37c80c18dbfbeb](https://user-images.githubusercontent.com/1490444/235938006-6c303f9d-8b81-43d0-b536-ae23f1f5bfd1.png\">","sha":"c1d76f8b4745334ff37491914b37c80c18dbfbeb){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #156267
Summary
Add a title to "Alerts Table inspect modal".
BEFORE
AFTER