Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] Make EntSearch app inputs explicit #156562

Merged
merged 2 commits into from
May 3, 2023

Conversation

sphilipse
Copy link
Member

Summary

This moves the Enterprise Search inputs for the bootstrap <App> to be explicit, rather than implicitly derived from what is and isn't excluded from a destructured object. Hopefully this will avoid us accidentally breaking the app because we changed the destructure or removed a variable somewhere.

@sphilipse sphilipse added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.9.0 labels May 3, 2023
@sphilipse sphilipse requested a review from a team May 3, 2023 14:43
@sphilipse sphilipse enabled auto-merge (squash) May 3, 2023 14:46
@sphilipse
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.3MB 2.3MB +213.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sphilipse sphilipse merged commit bceeec0 into elastic:main May 3, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants