Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] Switch to production ELSER model #156565

Merged

Conversation

demjened
Copy link
Contributor

@demjened demjened commented May 3, 2023

Summary

This PR switches the ELSER model to the production one .elser_model_1.

This has been manually tested with the Elasticsearch 8.8.0-SNAPSHOT Docker image from May 2.

ELSER_prod_model

@demjened demjened added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.8.0 v8.9.0 labels May 3, 2023
@demjened demjened marked this pull request as ready for review May 3, 2023 15:22
@demjened demjened requested a review from a team May 3, 2023 15:22
@demjened demjened enabled auto-merge (squash) May 3, 2023 15:31
@demjened demjened merged commit 8f0103c into elastic:main May 3, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #29 / detection engine api security and spaces enabled - Group 4 Detection rule type telemetry Detection rule telemetry "kql" rule type should show "legacy_notifications_disabled" to be "1" for rule that has at least "1" legacy action(s) and the alert is "disabled"/"in-active"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.3MB 2.3MB -9.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 3, 2023
## Summary

This PR switches the ELSER model to the production one `.elser_model_1`.

This has been manually tested with the Elasticsearch [8.8.0-SNAPSHOT
Docker image from May
2](https://artifacts-snapshot.elastic.co/elasticsearch/8.8.0-6ba23699/summary-8.8.0-SNAPSHOT.html).

![ELSER_prod_model](https://user-images.githubusercontent.com/14224983/235962097-9b7c15b5-2249-4900-b358-9f2906e3d10e.gif)

(cherry picked from commit 8f0103c)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 3, 2023
…156577)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Enterprise Search] Switch to production ELSER model
(#156565)](#156565)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Adam
Demjen","email":"demjened@gmail.com"},"sourceCommit":{"committedDate":"2023-05-03T15:55:22Z","message":"[Enterprise
Search] Switch to production ELSER model (#156565)\n\n##
Summary\r\n\r\nThis PR switches the ELSER model to the production one
`.elser_model_1`.\r\n\r\nThis has been manually tested with the
Elasticsearch [8.8.0-SNAPSHOT\r\nDocker image from
May\r\n2](https://artifacts-snapshot.elastic.co/elasticsearch/8.8.0-6ba23699/summary-8.8.0-SNAPSHOT.html).\r\n\r\n\r\n![ELSER_prod_model](https://user-images.githubusercontent.com/14224983/235962097-9b7c15b5-2249-4900-b358-9f2906e3d10e.gif)","sha":"8f0103cf165937ce1f7ec3910e430c6e0fe9d096","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.8.0","v8.9.0"],"number":156565,"url":"https://github.com/elastic/kibana/pull/156565","mergeCommit":{"message":"[Enterprise
Search] Switch to production ELSER model (#156565)\n\n##
Summary\r\n\r\nThis PR switches the ELSER model to the production one
`.elser_model_1`.\r\n\r\nThis has been manually tested with the
Elasticsearch [8.8.0-SNAPSHOT\r\nDocker image from
May\r\n2](https://artifacts-snapshot.elastic.co/elasticsearch/8.8.0-6ba23699/summary-8.8.0-SNAPSHOT.html).\r\n\r\n\r\n![ELSER_prod_model](https://user-images.githubusercontent.com/14224983/235962097-9b7c15b5-2249-4900-b358-9f2906e3d10e.gif)","sha":"8f0103cf165937ce1f7ec3910e430c6e0fe9d096"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156565","number":156565,"mergeCommit":{"message":"[Enterprise
Search] Switch to production ELSER model (#156565)\n\n##
Summary\r\n\r\nThis PR switches the ELSER model to the production one
`.elser_model_1`.\r\n\r\nThis has been manually tested with the
Elasticsearch [8.8.0-SNAPSHOT\r\nDocker image from
May\r\n2](https://artifacts-snapshot.elastic.co/elasticsearch/8.8.0-6ba23699/summary-8.8.0-SNAPSHOT.html).\r\n\r\n\r\n![ELSER_prod_model](https://user-images.githubusercontent.com/14224983/235962097-9b7c15b5-2249-4900-b358-9f2906e3d10e.gif)","sha":"8f0103cf165937ce1f7ec3910e430c6e0fe9d096"}}]}]
BACKPORT-->

Co-authored-by: Adam Demjen <demjened@gmail.com>
@demjened demjened deleted the demjened/elser-use-production-model branch May 5, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants