Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.8] [SecuritySolution] Fix minimize amd maximize panel actions (#156518) #156570

Merged
merged 1 commit into from
May 3, 2023
Merged

[8.8] [SecuritySolution] Fix minimize amd maximize panel actions (#156518) #156570

merged 1 commit into from
May 3, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.8:

Questions ?

Please refer to the Backport tool documentation

@angorayc
[SecuritySolution] Fix minimize amd maximize panel actions (elastic#1…
70eb80b 
…56518)

## Summary

Issues: elastic#155857 |
elastic#156253

This PR fixed minimize amd maximize panel actions in Security Dashboard
view.

https://user-images.githubusercontent.com/6295984/235910244-1cca8dda-cd4c-40b7-977a-69fa00021f81.mov

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>
(cherry picked from commit c278f4e)
@kibanamachine kibanamachine enabled auto-merge (squash) May 3, 2023 15:21
@kibanamachine kibanamachine mentioned this pull request May 3, 2023
Merged
1 task
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #38 / Visualize Visualize Reporting Screenshots Print PDF button becomes available when saved
  • [job] [logs] FTR Configs #38 / Visualize Visualize Reporting Screenshots Print PDF button is available if new

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.1MB 9.1MB +347.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @angorayc

@kibanamachine kibanamachine merged commit f4620b2 into elastic:8.8 May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@angorayc angorayc

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @kibana-ci @angorayc