[Enterprise Search] Search Apps. - fetch indices one-by-one #156571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloanelybutsurely
added
release_note:skip
sloanelybutsurely
force-pushed
the
search-app-indices-errors
branch
from
5f748af
to
7fe70a2
Compare
kderusso
approved these changes
May 3, 2023
x-pack/plugins/enterprise_search/server/lib/engines/fetch_indices_stats.ts
Outdated
Show resolved
Hide resolved
|
⏸️ ope! similar issues with pages fetching fields caps. more fixes incoming 🔧 |
sloanelybutsurely
force-pushed
the
search-app-indices-errors
branch
from
7fe70a2
to
8ff3897
Compare
|
@kderusso made some pretty significant changes to accommodate a similar change to search app field capabilities. mind taking another look? |
sloanelybutsurely
force-pushed
the
search-app-indices-errors
branch
from
c72f63f
to
b89d75e
Compare
sloanelybutsurely
force-pushed
the
search-app-indices-errors
branch
from
b89d75e
to
f63cf12
Compare
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 3, 2023
…156571) ## Summary fetches a search application's indices' stats one at a time. if even one index is not available the stats api returns an error[^1]. while fetching them all together is probably more efficient we have to get them one-by-one just in case one isn't available. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios [^1]: <details><summary>stats errors response</summary> <pre> { "error": { "root_cause": [ { "type": "index_not_found_exception", "reason": "no such index [sloane-books-001]", "resource.type": "index_or_alias", "resource.id": "sloane-books-001", "index_uuid": "_na_", "index": "sloane-books-001" } ], "type": "index_not_found_exception", "reason": "no such index [sloane-books-001]", "resource.type": "index_or_alias", "resource.id": "sloane-books-001", "index_uuid": "_na_", "index": "sloane-books-001" }, "status": 404 } </pre> </details> (cherry picked from commit 23a45bd)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 3, 2023
…56571) (#156624) # Backport This will backport the following commits from `main` to `8.8`: - [[Enterprise Search] Search Apps. - fetch indices one-by-one (#156571)](#156571) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sloane Perrault","email":"sloane.perrault@elastic.co"},"sourceCommit":{"committedDate":"2023-05-03T20:39:53Z","message":"[Enterprise Search] Search Apps. - fetch indices one-by-one (#156571)\n\n## Summary\r\n\r\nfetches a search application's indices' stats one at a time.\r\n\r\nif even one index is not available the stats api returns an error[^1].\r\nwhile fetching them all together is probably more efficient we have to\r\nget them one-by-one just in case one isn't available.\r\n\r\n### Checklist\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n[^1]: <details><summary>stats errors response</summary>\r\n <pre>\r\n {\r\n \"error\": {\r\n \"root_cause\": [\r\n {\r\n \"type\": \"index_not_found_exception\",\r\n \"reason\": \"no such index [sloane-books-001]\",\r\n \"resource.type\": \"index_or_alias\",\r\n \"resource.id\": \"sloane-books-001\",\r\n \"index_uuid\": \"_na_\",\r\n \"index\": \"sloane-books-001\"\r\n }\r\n ],\r\n \"type\": \"index_not_found_exception\",\r\n \"reason\": \"no such index [sloane-books-001]\",\r\n \"resource.type\": \"index_or_alias\",\r\n \"resource.id\": \"sloane-books-001\",\r\n \"index_uuid\": \"_na_\",\r\n \"index\": \"sloane-books-001\"\r\n },\r\n \"status\": 404\r\n }\r\n </pre>\r\n</details>","sha":"23a45bde21b36be49a1174b9bde1fc340de67534","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.8.0","v8.9.0"],"number":156571,"url":"https://github.com/elastic/kibana/pull/156571","mergeCommit":{"message":"[Enterprise Search] Search Apps. - fetch indices one-by-one (#156571)\n\n## Summary\r\n\r\nfetches a search application's indices' stats one at a time.\r\n\r\nif even one index is not available the stats api returns an error[^1].\r\nwhile fetching them all together is probably more efficient we have to\r\nget them one-by-one just in case one isn't available.\r\n\r\n### Checklist\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n[^1]: <details><summary>stats errors response</summary>\r\n <pre>\r\n {\r\n \"error\": {\r\n \"root_cause\": [\r\n {\r\n \"type\": \"index_not_found_exception\",\r\n \"reason\": \"no such index [sloane-books-001]\",\r\n \"resource.type\": \"index_or_alias\",\r\n \"resource.id\": \"sloane-books-001\",\r\n \"index_uuid\": \"_na_\",\r\n \"index\": \"sloane-books-001\"\r\n }\r\n ],\r\n \"type\": \"index_not_found_exception\",\r\n \"reason\": \"no such index [sloane-books-001]\",\r\n \"resource.type\": \"index_or_alias\",\r\n \"resource.id\": \"sloane-books-001\",\r\n \"index_uuid\": \"_na_\",\r\n \"index\": \"sloane-books-001\"\r\n },\r\n \"status\": 404\r\n }\r\n </pre>\r\n</details>","sha":"23a45bde21b36be49a1174b9bde1fc340de67534"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156571","number":156571,"mergeCommit":{"message":"[Enterprise Search] Search Apps. - fetch indices one-by-one (#156571)\n\n## Summary\r\n\r\nfetches a search application's indices' stats one at a time.\r\n\r\nif even one index is not available the stats api returns an error[^1].\r\nwhile fetching them all together is probably more efficient we have to\r\nget them one-by-one just in case one isn't available.\r\n\r\n### Checklist\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n[^1]: <details><summary>stats errors response</summary>\r\n <pre>\r\n {\r\n \"error\": {\r\n \"root_cause\": [\r\n {\r\n \"type\": \"index_not_found_exception\",\r\n \"reason\": \"no such index [sloane-books-001]\",\r\n \"resource.type\": \"index_or_alias\",\r\n \"resource.id\": \"sloane-books-001\",\r\n \"index_uuid\": \"_na_\",\r\n \"index\": \"sloane-books-001\"\r\n }\r\n ],\r\n \"type\": \"index_not_found_exception\",\r\n \"reason\": \"no such index [sloane-books-001]\",\r\n \"resource.type\": \"index_or_alias\",\r\n \"resource.id\": \"sloane-books-001\",\r\n \"index_uuid\": \"_na_\",\r\n \"index\": \"sloane-books-001\"\r\n },\r\n \"status\": 404\r\n }\r\n </pre>\r\n</details>","sha":"23a45bde21b36be49a1174b9bde1fc340de67534"}}]}] BACKPORT--> Co-authored-by: Sloane Perrault <sloane.perrault@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fetches a search application's indices' stats one at a time.
if even one index is not available the stats api returns an error1. while fetching them all together is probably more efficient we have to get them one-by-one just in case one isn't available.
Checklist
Footnotes
stats errors response
{ "error": { "root_cause": [ { "type": "index_not_found_exception", "reason": "no such index [sloane-books-001]", "resource.type": "index_or_alias", "resource.id": "sloane-books-001", "index_uuid": "_na_", "index": "sloane-books-001" } ], "type": "index_not_found_exception", "reason": "no such index [sloane-books-001]", "resource.type": "index_or_alias", "resource.id": "sloane-books-001", "index_uuid": "_na_", "index": "sloane-books-001" }, "status": 404 }↩