Not selecting any days in alerts filter maps to all weekdays #156913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ersin-erdal
added
release_note:fix
Team:ResponseOps
|
Pinging @elastic/response-ops (Team:ResponseOps) |
Zacqary
approved these changes
May 8, 2023
| import { AlertHit, SummarizedAlerts } from '@kbn/alerting-plugin/server/types'; | ||
| import { ParsedTechnicalFields } from '../../common'; | ||
| import { ParsedExperimentalFields } from '../../common/parse_experimental_fields'; | ||
| import { IRuleDataClient, IRuleDataReader } from '../rule_data_client'; | ||
|
|
||
| const MAX_ALERT_DOCS_TO_RETURN = 100; | ||
| export const ISO_WEEKDAYS: IsoWeekday[] = [1, 2, 3, 4, 5, 6, 7]; |
There was a problem hiding this comment.
Already exported from @kbn/triggers-actions-ui-plugin/common/constants, but probably should be exported from alerting-plugin. Can you move this there?
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @ersin-erdal |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
ersin-erdal
added a commit
to ersin-erdal/kibana
that referenced
this pull request
May 9, 2023
…#156913) Fixes: elastic#156878 As discussed in the issue just turning `if alert is generated within timeframe` on should not change the filter scope. And the UI should not confuse the users by setting some days as default. And as discussed in elastic#154680, default hours filter should cover the whole day. Therefore, this PR sets default alerts filter options as: ``` { days: [], hours: { start: '00:00', end: '00:00', }, }; ``` empty days array maps to all weekdays `[1,2,3,4,5,6,7]` and hours `00:00 -> 00:00` maps to `00:00 -> 24:00` (cherry picked from commit d157389) # Conflicts: # x-pack/plugins/rule_registry/server/utils/create_get_summarized_alerts_fn.ts
ersin-erdal
added a commit
that referenced
this pull request
May 15, 2023
…156913) (#157211) # Backport This will backport the following commits from `main` to `8.8`: - [Not selecting any days in alerts filter maps to all weekdays (#156913)](#156913) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ersin Erdal","email":"92688503+ersin-erdal@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-09T15:29:14Z","message":"Not selecting any days in alerts filter maps to all weekdays (#156913)\n\nFixes: #156878\r\n\r\nAs discussed in the issue just turning `if alert is generated within\r\ntimeframe` on should not change the filter scope.\r\nAnd the UI should not confuse the users by setting some days as default.\r\n\r\nAnd as discussed in #154680, default hours filter should cover the whole\r\nday.\r\n\r\nTherefore, this PR sets default alerts filter options as:\r\n```\r\n {\r\n days: [],\r\n hours: {\r\n start: '00:00',\r\n end: '00:00',\r\n },\r\n };\r\n```\r\n\r\nempty days array maps to all weekdays `[1,2,3,4,5,6,7]`\r\nand hours `00:00 -> 00:00` maps to `00:00 -> 24:00`","sha":"d15738989a6544c9b939cde5afc3533c9850d7d4","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:ResponseOps","v8.8.0","v8.9.0"],"number":156913,"url":"https://github.com/elastic/kibana/pull/156913","mergeCommit":{"message":"Not selecting any days in alerts filter maps to all weekdays (#156913)\n\nFixes: #156878\r\n\r\nAs discussed in the issue just turning `if alert is generated within\r\ntimeframe` on should not change the filter scope.\r\nAnd the UI should not confuse the users by setting some days as default.\r\n\r\nAnd as discussed in #154680, default hours filter should cover the whole\r\nday.\r\n\r\nTherefore, this PR sets default alerts filter options as:\r\n```\r\n {\r\n days: [],\r\n hours: {\r\n start: '00:00',\r\n end: '00:00',\r\n },\r\n };\r\n```\r\n\r\nempty days array maps to all weekdays `[1,2,3,4,5,6,7]`\r\nand hours `00:00 -> 00:00` maps to `00:00 -> 24:00`","sha":"d15738989a6544c9b939cde5afc3533c9850d7d4"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156913","number":156913,"mergeCommit":{"message":"Not selecting any days in alerts filter maps to all weekdays (#156913)\n\nFixes: #156878\r\n\r\nAs discussed in the issue just turning `if alert is generated within\r\ntimeframe` on should not change the filter scope.\r\nAnd the UI should not confuse the users by setting some days as default.\r\n\r\nAnd as discussed in #154680, default hours filter should cover the whole\r\nday.\r\n\r\nTherefore, this PR sets default alerts filter options as:\r\n```\r\n {\r\n days: [],\r\n hours: {\r\n start: '00:00',\r\n end: '00:00',\r\n },\r\n };\r\n```\r\n\r\nempty days array maps to all weekdays `[1,2,3,4,5,6,7]`\r\nand hours `00:00 -> 00:00` maps to `00:00 -> 24:00`","sha":"d15738989a6544c9b939cde5afc3533c9850d7d4"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #156878
As discussed in the issue just turning
if alert is generated within timeframeon should not change the filter scope.And the UI should not confuse the users by setting some days as default.
And as discussed in #154680, default hours filter should cover the whole day.
Therefore, this PR sets default alerts filter options as:
empty days array maps to all weekdays
[1,2,3,4,5,6,7]and hours
00:00 -> 00:00maps to00:00 -> 24:00