Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract fatal notification into fatalError service, add support for EuiToast notifications #15749

Merged
merged 38 commits into from
Jan 27, 2018
+1,059 −464
Merged

Extract fatal notification into fatalError service, add support for EuiToast notifications #15749

Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
5b16537
Reorganize notify/lib files. Extract fatal notification into a fatalE…
cjcenizal Dec 21, 2017
25bde88
Import Notifier from ui/notify module.
cjcenizal Dec 21, 2017
2ebadc7
Convert notify/lib tests to use Jest.
cjcenizal Dec 22, 2017
45f4af1
Move kbn-notifications directive definition from directives.js to not…
cjcenizal Dec 22, 2017
4db5249
Remove kbn-notifications directive import from typeahead.
cjcenizal Dec 22, 2017
4a4943e
Add basic mechanism for surfacing toasts.
cjcenizal Dec 22, 2017
adc1de5
Use toast notifications in Dashboard.
cjcenizal Dec 22, 2017
88c3051
Use toast notifications in Visualize.
cjcenizal Dec 22, 2017
d3505f8
Use toast notifications in Management.
cjcenizal Dec 22, 2017
e8038b1
Extend toast lifetime to 6 seconds.
cjcenizal Dec 22, 2017
5ed6a71
Add tests for GlobalToastList.
cjcenizal Dec 22, 2017
b26000b
Update state error handling test to assert against thrown error inste…
cjcenizal Jan 5, 2018
3e8e8e6
Temporarily skip failing tests.
cjcenizal Jan 3, 2018
733070c
Use single quotation marks when referring to a full name of an object.
cjcenizal Jan 8, 2018
dd1e3a6
Fix tests.
cjcenizal Jan 5, 2018
ee107e3
Fix input control vis and markdown vis tests by configuring functiona…
cjcenizal Jan 10, 2018
a5ae513
Fix Dashboard save tests.
cjcenizal Jan 10, 2018
6c26726
Last minute polish.
cjcenizal Jan 10, 2018
18da564
Use Chris's more efficient syntax.
cjcenizal Jan 25, 2018
818612b
Add addSuccess, addWarning, and addDanger convenience methdos to Toas…
cjcenizal Jan 25, 2018
7763316
Update ToastNotifications to accept strings as well as objects.
cjcenizal Jan 25, 2018
9dede7d
Remove all use cases of notify.info. Replace missing indices banner n…
cjcenizal Jan 25, 2018
78bfe67
Remove notify.info method.
cjcenizal Jan 25, 2018
bf0f4bb
Auto-dismiss missingIndicesMessage after 15 seconds.
cjcenizal Jan 25, 2018
c37ae91
Rename missingIndicesMessage to createFirstIndexPatternPrompt.
cjcenizal Jan 25, 2018
cb568ae
Remove unit tests for notifier info method.
cjcenizal Jan 25, 2018
7472600
Fix Dashboard and Saved Search test.
cjcenizal Jan 26, 2018
13bbfc4
Fix bug with toast dismissal logic.
cjcenizal Jan 26, 2018
9c42f06
Update testSubjects.exists to accept a timeout argument.
cjcenizal Jan 26, 2018
6404ba6
Update toastNotifications.add to return the new toast.
cjcenizal Jan 26, 2018
81799fc
Add documentation on UI systems.
cjcenizal Jan 26, 2018
eaa1141
Change 'No index pattern' prompt to use warning color.
cjcenizal Jan 26, 2018
c89ad15
Fix discover functional tests.
cjcenizal Jan 26, 2018
fb7d9e4
Add note on functional test use cases to docs.
cjcenizal Jan 26, 2018
545589d
Improve structure of toast docs.
cjcenizal Jan 26, 2018
e036a2d
Increase functional test timeout to 3 minutes.
cjcenizal Jan 26, 2018
a990b0c
Skip some flaky tests.
cjcenizal Jan 27, 2018
a898367
Fix copy to clipboard tests.
cjcenizal Jan 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change 'No index pattern' prompt to use warning color.
  • Loading branch information
@cjcenizal
cjcenizal committed Jan 26, 2018

Verified

This commit was signed with the committer’s verified signature.
pradyunsg Pradyun Gedam
GPG key ID: DA17C4B29CB32E4B
Verified
Learn about vigilant mode
commit eaa1141ca7d31b8b6d16f22adb2fc07c1002ad86
2 changes: 1 addition & 1 deletion src/ui/public/chrome/directives/kbn_chrome.html
View file
Original file line number Diff line number Diff line change
@@ -14,7 +14,7 @@
list="notifList"
></kbn-notifications>

<div ng-if="createFirstIndexPatternPrompt.isVisible" class="euiCallOut euiCallOut--primary noIndicesMessage">
<div ng-if="createFirstIndexPatternPrompt.isVisible" class="euiCallOut euiCallOut--warning noIndicesMessage">
<div class="euiCallOutHeader">
<svg class="euiIcon euiCallOutHeader__icon euiIcon--medium" aria-hidden="true" width="16" height="16" viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg">
<path d="M8.3 10.717H6.7v-4h1.6v4zm-1.6-5.71a.83.83 0 0 1 .207-.578c.137-.153.334-.229.59-.229.256 0 .454.076.594.23.14.152.209.345.209.576 0 .228-.07.417-.21.568-.14.15-.337.226-.593.226-.256 0-.453-.075-.59-.226a.81.81 0 0 1-.207-.568zM7.5 13A5.506 5.506 0 0 1 2 7.5C2 4.467 4.467 2 7.5 2S13 4.467 13 7.5 10.533 13 7.5 13m0-12a6.5 6.5 0 1 0 0 13 6.5 6.5 0 0 0 0-13"