Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip interactive setup functional tests #157863

Merged
merged 1 commit into from
May 16, 2023
Merged

Unskip interactive setup functional tests #157863

merged 1 commit into from
May 16, 2023

Conversation

legrego
Copy link
Member

@legrego legrego commented May 16, 2023

Resolves #157017
Resolves #157018

Unskips our Interactive Setup functional tests, which started failing after a recent ES snapshot promotion. This was caused by a regression in Elasticsearch, which was resolved via elastic/elasticsearch#96061.

I will not be running a flaky test suite here, as these tests were consistently failing, as opposed to flaky.

@legrego legrego added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels May 16, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 400 404 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 480 484 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@legrego legrego marked this pull request as ready for review May 16, 2023 12:48
@legrego legrego requested a review from a team as a code owner May 16, 2023 12:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

thomheymann
thomheymann approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@thomheymann thomheymann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for re-enabling these! ❤️

@legrego legrego merged commit 97abfaa into elastic:main May 16, 2023
jasonrhodes pushed a commit that referenced this pull request May 17, 2023
@legrego @jasonrhodes
Unskip interactive setup functional tests (#157863)
147b5b5 
Resolves #157017
Resolves #157018

Unskips our Interactive Setup functional tests, which started failing
after a recent ES snapshot promotion. This was caused by a regression in
Elasticsearch, which was resolved via
elastic/elasticsearch#96061.

I will not be running a flaky test suite here, as these tests were
consistently failing, as opposed to flaky.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomheymann thomheymann thomheymann approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.9.0
Projects
None yet
Milestone
No milestone
5 participants
@legrego @kibana-ci @elasticmachine @thomheymann @kibanamachine