[Migrations] Systematically wait for newly created indices to turn green #157973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsoldevila
added
bug
|
Pinging @elastic/kibana-core (Team:Core) |
gsoldevila
changed the title
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
pgayvallet
approved these changes
May 17, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 17, 2023
…een (elastic#157973) Tackles elastic#157968 When creating new indices during SO migrations, we used to rely on the `res.acknowledged && res.shardsAcknowledged` of the `esClient.indices.create(...)` to determine that the indices are ready to use. However, we believe that due to certain race conditions, this can cause Kibana migrations to fail (refer to the [related issue](elastic#157968)). This PR aims at fixing recent CI failures by adding a systematic `waitForIndexStatus` after creating an index. (cherry picked from commit 71125b1)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 17, 2023
…urn green (#157973) (#157993) # Backport This will backport the following commits from `main` to `8.8`: - [[Migrations] Systematically wait for newly created indices to turn green (#157973)](#157973) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2023-05-17T13:34:51Z","message":"[Migrations] Systematically wait for newly created indices to turn green (#157973)\n\nTackles https://github.com/elastic/kibana/issues/157968\r\n\r\nWhen creating new indices during SO migrations, we used to rely on the\r\n`res.acknowledged && res.shardsAcknowledged` of the\r\n`esClient.indices.create(...)` to determine that the indices are ready\r\nto use.\r\n\r\nHowever, we believe that due to certain race conditions, this can cause\r\nKibana migrations to fail (refer to the [related\r\nissue](https://github.com/elastic/kibana/issues/157968)).\r\n\r\nThis PR aims at fixing recent CI failures by adding a systematic\r\n`waitForIndexStatus` after creating an index.","sha":"71125b192e86ddc3d6747c5b14b92e669eba360f","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Core","release_note:skip","Feature:Migrations","backport:prev-minor","v8.8.0","v8.9.0","v8.8.1"],"number":157973,"url":"https://github.com/elastic/kibana/pull/157973","mergeCommit":{"message":"[Migrations] Systematically wait for newly created indices to turn green (#157973)\n\nTackles https://github.com/elastic/kibana/issues/157968\r\n\r\nWhen creating new indices during SO migrations, we used to rely on the\r\n`res.acknowledged && res.shardsAcknowledged` of the\r\n`esClient.indices.create(...)` to determine that the indices are ready\r\nto use.\r\n\r\nHowever, we believe that due to certain race conditions, this can cause\r\nKibana migrations to fail (refer to the [related\r\nissue](https://github.com/elastic/kibana/issues/157968)).\r\n\r\nThis PR aims at fixing recent CI failures by adding a systematic\r\n`waitForIndexStatus` after creating an index.","sha":"71125b192e86ddc3d6747c5b14b92e669eba360f"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157973","number":157973,"mergeCommit":{"message":"[Migrations] Systematically wait for newly created indices to turn green (#157973)\n\nTackles https://github.com/elastic/kibana/issues/157968\r\n\r\nWhen creating new indices during SO migrations, we used to rely on the\r\n`res.acknowledged && res.shardsAcknowledged` of the\r\n`esClient.indices.create(...)` to determine that the indices are ready\r\nto use.\r\n\r\nHowever, we believe that due to certain race conditions, this can cause\r\nKibana migrations to fail (refer to the [related\r\nissue](https://github.com/elastic/kibana/issues/157968)).\r\n\r\nThis PR aims at fixing recent CI failures by adding a systematic\r\n`waitForIndexStatus` after creating an index.","sha":"71125b192e86ddc3d6747c5b14b92e669eba360f"}}]}] BACKPORT--> Co-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co>
rudolf
added
the
Epic:ScaleMigrations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tackles #157968
When creating new indices during SO migrations, we used to rely on the
res.acknowledged && res.shardsAcknowledgedof theesClient.indices.create(...)to determine that the indices are ready to use.However, we believe that due to certain race conditions, this can cause Kibana migrations to fail (refer to the related issue).
This PR aims at fixing recent CI failures by adding a systematic
waitForIndexStatusafter creating an index.