Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Endpoint RBAC integration with AppFeatures architecture #158646
[Security Solution] Endpoint RBAC integration with AppFeatures architecture #158646
Changes from all commits
1b8797c
2f483d4
058ef8e
66f1af7
a42d97f
4a845ac
700e427
875618a
6f3a8c0
03e0144
fbac01c
951a94e
35e63f9
09859b1
7d1bd5a
c45fced
9d19cd7
6f2a978
1d24002
6752f40
b1e52a4
60f524b
62274b6
928e06e
2670bfe
92e2792
0332959
416deac
f4c8038
c8d1cde
71e7c7e
b9a190f
dd180f4
81b146a
69d0fc1
1333c03
96a655d
546e77c
0c6f185
af07bef
5502257
e79bd69
30e6791
0469bd3
312c905
84a1a1b
fb074cc
080eebf
ec1a537
5f67ce3
6b501ad
475fec2
9d20adb
fa2bf70
405cb33
743c53c
44cf1f2
89125b1
506d969
224339f
736a9fe
de1f10b
b45cd2e
a2e0409
8a54490
186a0d0
873a9e0
4a7fde9
2bcf98c
5e29b2a
ce77cef
bf6a101
b2016b6
bdfff4f
58739a3
73be171
cf3287a
7ad6814
6119282
54a553f
89a8789
b01fe23
d08e788
dd8921c
7923438
9421ba5
fb1abc4
110edee
2510d5d
945dfae
a66b7d5
d042e6f
c3700f7
f5682e9
8a81b1d
64a9c08
de0d016
782d0be
3443c94
affadf4
dc71fcb
fdb1bb4
7b19bfb
0dac524
89d91c5
246629a
9cf5e9d
b691fac
39842e0
e5073a6
edf01ae
21a4ea7
a02f6d3
70af547
d58adb7
2072c57
d9eb3f9
f583879
df04ccf
60b9fd8
df53a36
47c0473
34c4061
c433187
b117535
5d74bb2
0e55eba
2bee539
7759f9b
11d820d
3ddc502
24330f2
2e3f284
e70e96d
d22c72d
686bc2e
7d3b521
3d82e8e
d7c3b40
4d9f0c3
6a8f13e
ce0bec1
5068316
c67ba35
5fae537
57b5a5d
44257e0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these values final? or just preliminary until we get around to creating them in accordance to the PLI spreadsheet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These appFeatures represent the PLI in the spreadsheet, they are final. However, I am not familiar enough with the endpoint logic to be 100% sure I implemented the correct scope, if you guys think we should include something else, or something less, or change the names of the flags, I'll be happy to adapt it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. We'll likely adjust it. I'm thinking we create an individual item for each response action rather than combine them all into one. that gives us the freedom to ensure that future Response actions can be used in different PLI's if any new ones come up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There will be only one
AppFeatureKey
for each PLI in the spreadsheet, the granularity should be configured at the Kibana feature level here:kibana/x-pack/plugins/security_solution/server/lib/app_features/security_kibana_features.ts
Lines 170 to 198 in 4d9f0c3