-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Console] Add a setting to disable the a11y overlay #158844
Conversation
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @yuliacech! I've tested locally and code changes lgtm 🚀
Thanks a lot for your review, @sabarasaba! |
Merging this after running the flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2349 twice with 200 iterations. |
Also confirmed the ui copy with @alaudazzi |
Summary
Fixes #16139
This PR adds a setting in Console that allows to disable the a11y overlay. The default will be set to
enabled
so that the default behaviour should not change. A user can disable the overlay in their browser and the setting is saved in local storage. So that other users are not affected by that change.The reason to allow disabling the overlay is that it can be flaky and sometimes it's displayed when not intended. The code relies on
querySelector
(see this file) so I think that causes the flakiness and that is very difficult to test reliably.Screenshot
A11y overlay (no changes)
Settings modal with the new option to disable the a11y overlay
How to test
Flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2346
Checklist