[FullStory] Limit number of pageVars #159725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
bug
afharo
commented
Jun 14, 2023
Comment on lines
+109
to
+113
| if ( | ||
| typeof isElasticCloudUser === 'boolean' || | ||
| typeof cloudIsElasticStaffOwned === 'boolean' || | ||
| cloudTrialEndDate | ||
| ) { |
There was a problem hiding this comment.
we promoted cloudIsElasticStaffOwned and cloudTrialEndDate to the user level because they are account-related.
Comment on lines
-89
to
-92
| // Keeping these fields for backwards compatibility. | ||
| if (nonUserContext.applicationId) nonUserContext.app_id = nonUserContext.applicationId; | ||
| if (nonUserContext.entityId) nonUserContext.ent_id = nonUserContext.entityId; | ||
| if (nonUserContext.cloudId) nonUserContext.org_id = nonUserContext.cloudId; |
There was a problem hiding this comment.
Since we are mostly interested in trial users, most reports don't care about BWC.
Also, we've had these for a few minors, so there should be enough overlap of both to compare with previous versions.
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @afharo |
|
Pinging @elastic/kibana-core (Team:Core) |
|
Pinging @elastic/platform-onboarding (Team:Journey/Onboarding) |
afharo
added
release_note:skip
pgayvallet
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When testing #159549, we noticed that the new field was not coming through to FullStory.
The reason, FS's limit of reporting maximum 20 attributes per page.
@shahinakmal and I went through the list of currently reported context vars, and came up with the list that makes more sense to us right now.
Now we can filter the sessions by
servelessproject type 🎉Checklist
For maintainers