Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Add dynamic mapping for tsdb time_series_metric #159789

Merged
merged 11 commits into from
Jun 20, 2023
Merged

[Fleet] Add dynamic mapping for tsdb time_series_metric #159789

merged 11 commits into from
Jun 20, 2023

Conversation

criamico
Copy link
Contributor

@criamico criamico commented Jun 15, 2023 •
edited
Loading

Closes #155004

Summary

Add dynamic mapping for tsdb time_series_metric. The logic is replacing metric_type with time_series_metric in dynamic fields that have a wildcard in the name.

Screenshot 2023-06-20 at 15 33 37

Checklist

@criamico criamico added the Team:Fleet Team label for Observability Data Collection Fleet team label Jun 15, 2023
@criamico criamico self-assigned this Jun 15, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@criamico criamico added the release_note:skip Skip the PR/issue when compiling release notes label Jun 15, 2023
@criamico
Copy link
Contributor Author

@elasticmachine merge upstream

@criamico
Copy link
Contributor Author

@elasticmachine merge upstream

@criamico
Copy link
Contributor Author

@elasticmachine merge upstream

@criamico criamico marked this pull request as ready for review June 20, 2023 14:16
@criamico criamico requested a review from a team as a code owner June 20, 2023 14:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

juliaElastic
juliaElastic approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 411 415 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 494 498 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

@criamico criamico merged commit ce6bdc9 into elastic:main Jun 20, 2023
@kibanamachine kibanamachine added v8.9.0 backport:skip This commit does not require backporting labels Jun 20, 2023
@criamico criamico deleted the 155004_tsdb_dynamic_mapping branch June 20, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaElastic juliaElastic juliaElastic approved these changes

Assignees

@criamico criamico

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet] TSDB: need metric_type mapping for dynamic templates
6 participants
@criamico @apmmachine @elasticmachine @kibana-ci @juliaElastic @kibanamachine