[7.17] Sync Storybook version #159854
Merged
[7.17] Sync Storybook version #159854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ikuni17
commented
Jun 20, 2023
Ikuni17
commented
Jun 20, 2023
Comment on lines
+33
to
+34
| // FAILING: https://github.com/elastic/kibana/issues/141543 | ||
| describe.skip('renderApp (APM)', () => { |
There was a problem hiding this comment.
This test has a known issue (#141543) and doesn't exist on main anymore. I'm guessing the React upgrade caused it to resurface here.
…na into chore/159508/sync-storybook
Ikuni17
added
release_note:skip
* Update Storybook to 6.5 * Add @types/react-syntax-highlighter * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * fix type error * include some deduping and patch version bumping to encourage yarn to do the right thing * fix path to canvas addon * remove addon build * fix some type issues * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * 6.5.12 Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: spalger <spencer@elastic.co>
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@storybook/addon-a11y](https://togithub.com/storybookjs/storybook/tree/main/addons/a11y) ([source](https://togithub.com/storybookjs/storybook)) | [`^6.5.15` -> `^6.5.16`](https://renovatebot.com/diffs/npm/@storybook%2faddon-a11y/6.5.15/6.5.16) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/addon-actions](https://togithub.com/storybookjs/storybook/tree/main/addons/actions) ([source](https://togithub.com/storybookjs/storybook)) | [`^6.5.15` -> `^6.5.16`](https://renovatebot.com/diffs/npm/@storybook%2faddon-actions/6.5.15/6.5.16) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/addon-controls](https://togithub.com/storybookjs/storybook/tree/next/addons/controls) ([source](https://togithub.com/storybookjs/storybook)) | [`^6.5.15` -> `^6.5.16`](https://renovatebot.com/diffs/npm/@storybook%2faddon-controls/6.5.15/6.5.16) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/addon-docs](https://togithub.com/storybookjs/storybook/tree/main/addons/docs) ([source](https://togithub.com/storybookjs/storybook)) | [`^6.5.15` -> `^6.5.16`](https://renovatebot.com/diffs/npm/@storybook%2faddon-docs/6.5.15/6.5.16) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/addon-essentials](https://togithub.com/storybookjs/storybook/tree/main/addons/essentials) ([source](https://togithub.com/storybookjs/storybook)) | [`^6.5.15` -> `^6.5.16`](https://renovatebot.com/diffs/npm/@storybook%2faddon-essentials/6.5.15/6.5.16) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/addon-storyshots](https://togithub.com/storybookjs/storybook/tree/main/addons/storyshots/storyshots-core) ([source](https://togithub.com/storybookjs/storybook)) | [`^6.5.15` -> `^6.5.16`](https://renovatebot.com/diffs/npm/@storybook%2faddon-storyshots/6.5.15/6.5.16) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/addons](https://togithub.com/storybookjs/storybook/tree/main/lib/addons) ([source](https://togithub.com/storybookjs/storybook)) | [`^6.5.15` -> `^6.5.16`](https://renovatebot.com/diffs/npm/@storybook%2faddons/6.5.15/6.5.16) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/api](https://togithub.com/storybookjs/storybook/tree/main/lib/api) ([source](https://togithub.com/storybookjs/storybook)) | [`^6.5.15` -> `^6.5.16`](https://renovatebot.com/diffs/npm/@storybook%2fapi/6.5.15/6.5.16) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/client-api](https://togithub.com/storybookjs/storybook/tree/main/lib/client-api) ([source](https://togithub.com/storybookjs/storybook)) | [`^6.5.15` -> `^6.5.16`](https://renovatebot.com/diffs/npm/@storybook%2fclient-api/6.5.15/6.5.16) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/components](https://togithub.com/storybookjs/storybook/tree/main/lib/components) ([source](https://togithub.com/storybookjs/storybook)) | [`^6.5.15` -> `^6.5.16`](https://renovatebot.com/diffs/npm/@storybook%2fcomponents/6.5.15/6.5.16) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/core](https://togithub.com/storybookjs/storybook/tree/main/lib/core) ([source](https://togithub.com/storybookjs/storybook)) | [`^6.5.15` -> `^6.5.16`](https://renovatebot.com/diffs/npm/@storybook%2fcore/6.5.15/6.5.16) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/core-common](https://togithub.com/storybookjs/storybook/tree/main/lib/core) ([source](https://togithub.com/storybookjs/storybook)) | [`^6.5.15` -> `^6.5.16`](https://renovatebot.com/diffs/npm/@storybook%2fcore-common/6.5.15/6.5.16) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/core-events](https://togithub.com/storybookjs/storybook/tree/main/lib/core-events) ([source](https://togithub.com/storybookjs/storybook)) | [`^6.5.15` -> `^6.5.16`](https://renovatebot.com/diffs/npm/@storybook%2fcore-events/6.5.15/6.5.16) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/node-logger](https://togithub.com/storybookjs/storybook/tree/main/lib/node-logger) ([source](https://togithub.com/storybookjs/storybook)) | [`^6.5.15` -> `^6.5.16`](https://renovatebot.com/diffs/npm/@storybook%2fnode-logger/6.5.15/6.5.16) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/preview-web](https://togithub.com/storybookjs/storybook/tree/main/lib/preview-web) ([source](https://togithub.com/storybookjs/storybook)) | [`^6.5.15` -> `^6.5.16`](https://renovatebot.com/diffs/npm/@storybook%2fpreview-web/6.5.15/6.5.16) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/react](https://togithub.com/storybookjs/storybook/tree/main/app/react) ([source](https://togithub.com/storybookjs/storybook)) | [`^6.5.15` -> `^6.5.16`](https://renovatebot.com/diffs/npm/@storybook%2freact/6.5.15/6.5.16) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/theming](https://togithub.com/storybookjs/storybook/tree/main/lib/theming) ([source](https://togithub.com/storybookjs/storybook)) | [`^6.5.15` -> `^6.5.16`](https://renovatebot.com/diffs/npm/@storybook%2ftheming/6.5.15/6.5.16) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- <details> <summary>storybookjs/storybook</summary> [`v6.5.16`](https://togithub.com/storybookjs/storybook/releases/tag/v6.5.16) [Compare Source](https://togithub.com/storybookjs/storybook/compare/v6.5.15...v6.5.16) - Angular: Fix handling of docsMode option in angular builder [#&elastic#8203;20608](https://togithub.com/storybooks/storybook/pull/20608) - Angular: Fix webpackStatsJson types in angular-builder [#&elastic#8203;20296](https://togithub.com/storybooks/storybook/pull/20296) - Security: Upgrade json5 dependency [#&elastic#8203;20526](https://togithub.com/storybooks/storybook/pull/20526) </details> --- 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/elastic/kibana). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTkuNSIsInVwZGF0ZWRJblZlciI6IjM0LjExOS41In0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jon <jon@elastic.co>
](https://renovatebot.com){kind=link}
|
There are some issues in the SB preview, but they are also present in #160221. Unsure how long they have existed, or if they are a concern. If so, I'd say we open a separate issue to fix them. |
jbudz
reviewed
Jun 22, 2023
jbudz
reviewed
Jun 22, 2023
jbudz
reviewed
Jun 22, 2023
jbudz
approved these changes
Jun 22, 2023
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
History
To update your PR or re-run it, just comment with: cc @Ikuni17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings
7.17Storybook version in sync withmain. Closes #159508. Refer to issue for PRs which were backported.