-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POC] Connector adapters for alerting rule actions #159866
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
Feature:Actions/ConnectorTypes
Issues related to specific Connector Types on the Actions Framework
Feature:Actions/Framework
Issues related to the Actions Framework
labels
Jun 16, 2023
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @mikecote |
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Actions/ConnectorTypes
Issues related to specific Connector Types on the Actions Framework
Feature:Actions/Framework
Issues related to the Actions Framework
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this POC, I prototyped how we can have a connector, Email in this case, adapt itself to alerting rule actions so the user doesn't have to pass-through certain or any action parameters themselves through mustache.
The adapters support the following capabilities:
kibanaFooterLink
as a param, but I can remove it from being a valid/allowed param for alerting rules). TODO: modify code to enforce validation.Adapter example: https://github.com/elastic/kibana/pull/159866/files#diff-c496e4ab30fb220a62f4646a3bae3459ba9db34c3ca105fab312c5a604c23383R425
You can also load the UI and notice that I made it reflect the configuration for email connector so you can only, for demo purposes, select active action groups and you can only select on action group change. More to do in the cases scenario where we want to hide it from the connectors list and replace it with a checkbox..