Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AO] Fix developer console warnings related to rule details page #160034

Merged
merged 3 commits into from
Jun 21, 2023
Merged

[AO] Fix developer console warnings related to rule details page #160034

merged 3 commits into from
Jun 21, 2023

Conversation

maryam-saeidi
Copy link
Member

@maryam-saeidi maryam-saeidi commented Jun 20, 2023 •
edited
Loading

Fixes #159285

Summary

This PR fixes the following warnings.

First warning Second Warning
image image

🧪 How to test

Make sure the following components look like before.
image

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@maryam-saeidi maryam-saeidi marked this pull request as ready for review June 20, 2023 15:27
@maryam-saeidi maryam-saeidi requested review from a team as code owners June 20, 2023 15:27
@maryam-saeidi maryam-saeidi self-assigned this Jun 20, 2023
@maryam-saeidi maryam-saeidi added release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" labels Jun 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

maryam-saeidi
maryam-saeidi commented Jun 20, 2023
View reviewed changes
...ublic/application/sections/rule_details/components/rule_execution_summary_and_chart.test.tsx
target: {
value: 30,
},
await act(async () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-06-20 at 16 42 24

jcger
jcger approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@jcger jcger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

benakansara
benakansara approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@benakansara benakansara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcger jcger mentioned this pull request Jun 21, 2023
Closed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.4MB 1.4MB +281.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 411 415 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 492 496 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maryam-saeidi

@maryam-saeidi maryam-saeidi merged commit b6adcce into elastic:main Jun 21, 2023
@maryam-saeidi maryam-saeidi deleted the 159285-fix-developer-warnings branch June 21, 2023 10:15
@kibanamachine kibanamachine added v8.9.0 backport:skip This commit does not require backporting labels Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcger jcger jcger approved these changes

@benakansara benakansara benakansara approved these changes

Assignees

@maryam-saeidi maryam-saeidi

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Fix validateDOMNesting(...): <div> cannot appear as a descendant of <p> warning
7 participants
@maryam-saeidi @apmmachine @elasticmachine @kibana-ci @jcger @benakansara @kibanamachine