[Lens] Quick Function Incompatability Indicator Getting Cut Off #160046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
force-pushed
the
lens/indicator_cut
branch
from
0cc2080 to
f4f1cbb
Compare
mbondyra
added
Team:Visualizations
mbondyra
force-pushed
the
lens/indicator_cut
branch
from
f4f1cbb to
2b11dc0
Compare
|
Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations) |
dej611
approved these changes
Jun 21, 2023
| <EuiFlexItem grow={false} style={{ marginRight: euiTheme.size.xs }}> | ||
| {label} | ||
| <EuiFlexItem grow={false} style={{ marginRight: euiTheme.size.xs, minWidth: 0 }}> | ||
| <span className="lnsIndexPatternDimensionEditor__operationLabel">{label}</span> |
There was a problem hiding this comment.
nit: is still scss preferred over emotion css prop?
There was a problem hiding this comment.
Probably not, I just missed the change 😅 Will change!
mbondyra
force-pushed
the
lens/indicator_cut
branch
from
a8e2cee to
715d091
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #152520
Before
After
Also fixed broken theme and missing I18nProvider from the extra action that has a separate mounting point.
