Versioned common Space interface #160237
Merged
Versioned common Space interface #160237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeramysoucy
added
Team:Security
jeramysoucy
commented
Jun 26, 2023
| @@ -27,13 +27,14 @@ export const createMockSavedObjectsRepository = (spaces: any[] = []) => { | |||
| if (spaces.find((s) => s.id === id)) { | |||
| throw SavedObjectsErrorHelpers.decorateConflictError(new Error(), 'space conflict'); | |||
| } | |||
| return {}; | |||
| return { id, attributes }; | |||
There was a problem hiding this comment.
Returning a non-empty object now to satisfy the explicit conversion in the client.
jeramysoucy
commented
Jun 26, 2023
| throw SavedObjectsErrorHelpers.createGenericNotFoundError(type, id); | ||
| } | ||
| return {}; | ||
| return result[0]; |
There was a problem hiding this comment.
Returning a non-empty object now to satisfy the explicit conversion in the client.
jeramysoucy
commented
Jun 26, 2023
x-pack/plugins/spaces/server/spaces_client/spaces_client.test.ts
Outdated
Show resolved
Hide resolved
jeramysoucy
commented
Jun 26, 2023
|
Pinging @elastic/kibana-security (Team:Security) |
kc13greiner
reviewed
Jun 27, 2023
x-pack/plugins/spaces/server/spaces_client/spaces_client.test.ts
Outdated
Show resolved
Hide resolved
…-ref HEAD~1..HEAD --fix'
kc13greiner
reviewed
Jun 28, 2023
| _reserved: savedObject.attributes._reserved, | ||
| } as v1.Space; | ||
| } | ||
|
|
||
| private generateSpaceAttributes(space: v1.Space) { | ||
| return omit(space, ['id', '_reserved']); | ||
| return { |
💚 Build Succeeded
Metrics [docs]Module Count
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #159708
Summary
This PR replaces the common Space interface with a versioned interface per The road to versioned HTTP APIs doc, and guidance of Versioning Interfaces. Additionally, this PR replaces the implicit use of saved object attributes with an explicit conversion from the SO attributes to versioned interface properties.
Tests