Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Jest 22.0.6 #16041

Merged
merged 1 commit into from
Jan 16, 2018
Merged

Upgrade to Jest 22.0.6 #16041

merged 1 commit into from
Jan 16, 2018

Conversation

kimjoar
Copy link
Contributor

@kimjoar kimjoar commented Jan 15, 2018

No description provided.

@kimjoar kimjoar requested a review from cjcenizal January 15, 2018 00:48
expect(takeMountedSnapshot(component))
.toMatchSnapshot();

// Navigate to a different panel.
component.find('[data-test-subj="contextMenuPanelTitleButton"]').simulate('click');

await tick(20);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the requestAnimationFrame code in that component is the reason I had to do this.

@@ -1,22 +0,0 @@
// requestAnimationFrame isn't available in node so we need to polyfill it.
// Borrowed from https://gist.github.com/paulirish/1579671.
window.requestAnimationFrame = (() => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now available in Jest

@kimjoar
Copy link
Contributor Author

kimjoar commented Jan 15, 2018

jenkins, test this

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔨 LGTM!

@kimjoar kimjoar merged commit 039e24f into elastic:master Jan 16, 2018
kimjoar added a commit to kimjoar/kibana that referenced this pull request Jan 16, 2018
kimjoar added a commit that referenced this pull request Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants