-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synthetics] Make overview grid embeddable #160597
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
41c0d1c
to
2439b26
Compare
Warning: this will likely clash with my efforts on #187092. If this is a requirement that is ok but it should also ideally address the scalability concerns with larger deployments. |
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "group by" feature does not work in the embeddable.
Did we address @justinkambic's concerns about the scalability work he was doing here, or do we have a plan for that? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, need to do some smoke test
|
||
<EuiButton | ||
data-test-subj="syntheticsMonitorConfigurationSaveButton" | ||
isDisabled={!formState.isDirty} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to check isValid?
Manual test looks good so far, just noticed the sorting is not taken into account when using a grouping option: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note on the sorting with grouping, but i guess that need to be done at the synthetics component level
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Summary
Overview grid can be embedded as part of dashboard !!
Can be added by selecting type
Select Type -> Synthetics ->