Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Make overview grid embeddable #160597

Merged
merged 25 commits into from
Aug 13, 2024

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Jun 27, 2023

Summary

Overview grid can be embedded as part of dashboard !!

Can be added by selecting type Select Type -> Synthetics ->

image image

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 marked this pull request as ready for review July 22, 2024 16:27
@shahzad31 shahzad31 requested a review from a team as a code owner July 22, 2024 16:27
@shahzad31 shahzad31 added the release_note:skip Skip the PR/issue when compiling release notes label Jul 22, 2024
@justinkambic
Copy link
Contributor

Warning: this will likely clash with my efforts on #187092.

If this is a requirement that is ok but it should also ideally address the scalability concerns with larger deployments.

@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Jul 24, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "group by" feature does not work in the embeddable.

@shahzad31 shahzad31 requested a review from a team as a code owner August 8, 2024 09:10
@shahzad31 shahzad31 removed the request for review from a team August 8, 2024 09:53
@jasonrhodes
Copy link
Member

Did we address @justinkambic's concerns about the scalability work he was doing here, or do we have a plan for that? Thanks!

Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, need to do some smoke test


<EuiButton
data-test-subj="syntheticsMonitorConfigurationSaveButton"
isDisabled={!formState.isDirty}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to check isValid?

@kdelemme
Copy link
Contributor

Manual test looks good so far, just noticed the sorting is not taken into account when using a grouping option:
Below i'm sorting by status while grouping by monitor type, but the sort is not applied in the group. I guess that's also not working on the synthetics page itself, so not specific to this PR.

image

Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note on the sorting with grouping, but i guess that need to be done at the synthetics component level

@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 13, 2024

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 2c8ef46
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-160597-2c8ef4600308

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
synthetics 978 991 +13

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 853.6KB 924.4KB +70.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
synthetics 35.7KB 34.9KB -902.0B
Unknown metric groups

async chunk count

id before after diff
synthetics 10 14 +4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit f47f853 into elastic:main Aug 13, 2024
25 checks passed
@shahzad31 shahzad31 deleted the overview-embedd branch August 13, 2024 17:46
@shahzad31 shahzad31 added release_note:feature Makes this part of the condensed release notes and removed release_note:skip Skip the PR/issue when compiling release notes labels Aug 13, 2024
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:feature Makes this part of the condensed release notes Team:obs-ux-management Observability Management User Experience Team v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants