[Cases] Limit the number of attachments that can be added to a case simultaneously #161250
Conversation
adcoelho
changed the title
adcoelho
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
| @@ -218,17 +210,6 @@ export default ({ getService }: FtrProviderContext): void => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('should bulk create 100 file attachments when there is another attachment type in the request', async () => { | |||
There was a problem hiding this comment.
Do you remember why we had the test in the first place?
There was a problem hiding this comment.
Not really 😄 @jonathan-buttner ?
There was a problem hiding this comment.
Yeah so I think the file attachment code limits how many files can be attached to a case to 100, what this test was covering is that the code only counts file attachments and would ignore a different type of attachment when doing the counting.
Maybe we don't need it anymore if we're limiting the total attachments in a single request to 100 🤷♂️
I think we have some unit test coverage there too so we're probably ok.
There was a problem hiding this comment.
Thanks, Jonathan. It seems it is covered by the unit tests.
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @adcoelho |
Connected to #146945
Summary
I tried to create the tests following what we discussed offline.
BulkCreateCommentRequestRtinx-pack/plugins/cases/common/api/cases/comment/index.test.tsBulkCreateCommentRequestRtis used bybulkCreateChecklist
Delete any items that are not applicable to this PR.