Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Presentation] Migrate all usages of EuiPage*_Deprecated #161496

Merged
merged 13 commits into from
Jul 10, 2023

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jul 7, 2023

closes #161428

PR also updates examples title. Instead of naming the embeddable used, the title now reflects what the example demonstrates.

  • "Hello world embeddable" -> "Render embeddable"
  • "Todo embeddable" -> "Update embeddable state"
  • "List container embeddable" -> "Groups of embeddables"
  • "Dynamically adding children to a container" -> "Context menu"

There is a lot more that could be done to enhance these examples, but I did not want to get more side tracked then I already did.

@nreese
Copy link
Contributor Author

nreese commented Jul 10, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 408 412 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 487 491 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese marked this pull request as ready for review July 10, 2023 14:57
@nreese nreese requested a review from a team as a code owner July 10, 2023 14:57
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes v8.10.0 labels Jul 10, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson self-requested a review July 10, 2023 17:00
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through the code and everything looks good! Also ran this locally and read through the examples. We'll definitely need to revisit this, as there is a lot more we could demonstrate + plenty of ways to streamline the content but LGTM!

Hopefully the conflicts with #159837 won't be too bad!

@nreese nreese merged commit d3d0cdb into elastic:main Jul 10, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Presentation] Migrate all usages of EuiPage*_Deprecated
5 participants