-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Presentation] Migrate all usages of EuiPage*_Deprecated #161496
Conversation
…-ref HEAD~1..HEAD --fix'
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Pinging @elastic/kibana-presentation (Team:Presentation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked through the code and everything looks good! Also ran this locally and read through the examples. We'll definitely need to revisit this, as there is a lot more we could demonstrate + plenty of ways to streamline the content but LGTM!
Hopefully the conflicts with #159837 won't be too bad!
closes #161428
PR also updates examples title. Instead of naming the embeddable used, the title now reflects what the example demonstrates.
There is a lot more that could be done to enhance these examples, but I did not want to get more side tracked then I already did.