[Actions] Do not return system actions from GET APIs

[cnasikas]

Summary

This PR removes the ability to get system actions from GET APIs. Specifically:

• The Get action API throws a 404 error when requesting a system action
• The Bulk Get action API throws a 404 error when requesting a system action
• The Get All API filters out system actions
• The Get List Types API filters out system actions

Checklist

Delete any items that are not applicable to this PR.

• Unit or functional tests were updated or added to match the most common scenarios

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/response-ops (Team:ResponseOps)

[pmuellr]

I'm curious what this might break :-)

Basically, in the framework, as it's running, using the API client itself to do things; I guess mainly alerting.

At first I was thinking this might be blocking at the HTTP level, which seems probably fine (but who knows!), but blocking at the client API seems a lot more likely to break things ...

[cnasikas]

You are right @pmuellr. Also, we may need to access system actions and the actions client is the only way to do it (although we can expose dedicate functions for system actions). About the APIs, until we know what we want to do with them, it is better to not return system actions as removing them afterwards will be a breaking change.

[cnasikas]

@mikecote @pmuellr I applied the changes we discussed offline. The API will not return the system actions but the actions client will accept an option to return the system actions from the getAll and listTypes functions (defaulted to not return them). When I start working on the UI, I will create an internal API to return system actions. Could you please take another look?

[cnasikas]

buildkite test this

[ymao1]

LGTM!

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 1613160

Metrics [docs]

✅ unchanged

History

• 💔 Build #143867 failed 8f84dee
• 💔 Build #143813 failed f23abbc
• 💔 Build #143501 failed 5e17b4a
• 💔 Build #143474 failed 5e17b4a
• 💔 Build #143158 failed bb87ad3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas