[Infra UI] Hosts view test: fix apm services link #162147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
jennypavlova
added
Team:Infra Monitoring UI - DEPRECATED
|
100 passes build |
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jennypavlova
added a commit
to jennypavlova/kibana
that referenced
this pull request
Jul 19, 2023
Closes elastic#162051 Closes elastic#159368 ## Summary This PR aims to make the APM services link test more stable. For some reason, some of the query parameters are not present in the URL the moment we navigate but we can see in the screenshot that the correct dates are applied (it could be that the moment we load APM the URL is not updated - when checking locally those parameters exist in the URL) <img width="1612" alt="image" src="https://github.com/elastic/kibana/assets/14139027/2363108a-329e-4f28-a0d8-9f177d01d4ef"> --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit e98abd0) # Conflicts: # x-pack/test/functional/apps/infra/hosts_view.ts
jennypavlova
added a commit
that referenced
this pull request
Jul 19, 2023
…62216) # Backport This will backport the following commits from `main` to `8.9`: - [[Infra UI] Hosts view test: fix apm services link (#162147)](#162147) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2023-07-19T08:30:43Z","message":"[Infra UI] Hosts view test: fix apm services link (#162147)\n\nCloses #162051 #159368\r\n## Summary\r\n\r\nThis PR aims to make the APM services link test more stable. For some\r\nreason, some of the query parameters are not present in the URL the\r\nmoment we navigate but we can see in the screenshot that the correct\r\ndates are applied (it could be that the moment we load APM the URL is\r\nnot updated - when checking locally those parameters exist in the URL)\r\n<img width=\"1612\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/2363108a-329e-4f28-a0d8-9f177d01d4ef\">\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"e98abd0fb5896b573de7ab811534d134d15d7cb9","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Infra Monitoring UI","release_note:skip","backport:prev-minor","v8.10.0"],"number":162147,"url":"#162147 UI] Hosts view test: fix apm services link (#162147)\n\nCloses #162051 #159368\r\n## Summary\r\n\r\nThis PR aims to make the APM services link test more stable. For some\r\nreason, some of the query parameters are not present in the URL the\r\nmoment we navigate but we can see in the screenshot that the correct\r\ndates are applied (it could be that the moment we load APM the URL is\r\nnot updated - when checking locally those parameters exist in the URL)\r\n<img width=\"1612\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/2363108a-329e-4f28-a0d8-9f177d01d4ef\">\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"e98abd0fb5896b573de7ab811534d134d15d7cb9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"#162147 UI] Hosts view test: fix apm services link (#162147)\n\nCloses #162051 #159368\r\n## Summary\r\n\r\nThis PR aims to make the APM services link test more stable. For some\r\nreason, some of the query parameters are not present in the URL the\r\nmoment we navigate but we can see in the screenshot that the correct\r\ndates are applied (it could be that the moment we load APM the URL is\r\nnot updated - when checking locally those parameters exist in the URL)\r\n<img width=\"1612\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/2363108a-329e-4f28-a0d8-9f177d01d4ef\">\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"e98abd0fb5896b573de7ab811534d134d15d7cb9"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
Closes elastic#162051 Closes elastic#159368 ## Summary This PR aims to make the APM services link test more stable. For some reason, some of the query parameters are not present in the URL the moment we navigate but we can see in the screenshot that the correct dates are applied (it could be that the moment we load APM the URL is not updated - when checking locally those parameters exist in the URL) <img width="1612" alt="image" src="https://github.com/elastic/kibana/assets/14139027/2363108a-329e-4f28-a0d8-9f177d01d4ef"> --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #162051
Closes #159368
Summary
This PR aims to make the APM services link test more stable. For some reason, some of the query parameters are not present in the URL the moment we navigate but we can see in the screenshot that the correct dates are applied (it could be that the moment we load APM the URL is not updated - when checking locally those parameters exist in the URL)
