Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip Serverless Observability Tests / serverless observability UI navigation active sidenav section is auto opened on load #162323

Merged
merged 11 commits into from
Aug 22, 2023
Merged

Unskip Serverless Observability Tests / serverless observability UI navigation active sidenav section is auto opened on load #162323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8127b21
flaky run
Dosant Jul 20, 2023
9438ac3
Merge branch 'main' of github.com:elastic/kibana into dev/2023-07-20-…
Dosant Aug 21, 2023
fa701ed
flaky test
Dosant Aug 21, 2023
50e5be6
flaky test
Dosant Aug 21, 2023
1fa7d64
fix
Dosant Aug 21, 2023
1a1283d
fix flaky nav test
Dosant Aug 21, 2023
bb6edbc
revert loop changes
Dosant Aug 21, 2023
5fa7141
fix
Dosant Aug 21, 2023
8bcc230
revert formatting changes
Dosant Aug 21, 2023
4bf5c62
Merge branch 'main' into dev/2023-07-20-flaky-nav-test
kibanamachine Aug 21, 2023
f7aef36
Merge branch 'main' into dev/2023-07-20-flaky-nav-test
kibanamachine Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions x-pack/test_serverless/functional/page_objects/svl_common_navigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,17 @@ export function SvlCommonNavigationProvider(ctx: FtrProviderContext) {
},
async expectSectionOpen(sectionId: NavigationId) {
await this.expectSectionExists(sectionId);
const isOpen = await this.isSectionOpen(sectionId);
expect(isOpen).to.be(true);
await retry.waitFor(`section ${sectionId} to be open`, async () => {
const isOpen = await this.isSectionOpen(sectionId);
return isOpen;
});
},
async expectSectionClosed(sectionId: NavigationId) {
await this.expectSectionExists(sectionId);
const isOpen = await this.isSectionOpen(sectionId);
expect(isOpen).to.be(false);
await retry.waitFor(`section ${sectionId} to be closed`, async () => {
const isOpen = await this.isSectionOpen(sectionId);
return !isOpen;
});
},
async openSection(sectionId: NavigationId) {
await this.expectSectionExists(sectionId);
Expand Down
3 changes: 1 addition & 2 deletions x-pack/test_serverless/functional/test_suites/observability/navigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,7 @@ export default function ({ getPageObject, getService }: FtrProviderContext) {
await expectNoPageReload();
});

// FLAKY/BUG?: https://github.com/elastic/kibana/issues/162781
it.skip('active sidenav section is auto opened on load', async () => {
it('active sidenav section is auto opened on load', async () => {
await svlCommonNavigation.sidenav.openSection('project_settings_project_nav');
await svlCommonNavigation.sidenav.clickLink({ deepLinkId: 'management' });
await browser.refresh();
Expand Down
Loading