Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Migrations] Unskip migration integration tests after fixing #162648

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

dokmic
Copy link
Contributor

@dokmic dokmic commented Jul 27, 2023

Summary

Resolves #156117.

This PR just enables back the tests as they should have been fixed in #158182.

@dokmic dokmic added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes Feature:Migrations 8.10 candidate v8.8.3 v8.9.1 labels Jul 27, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dokmic dokmic marked this pull request as ready for review July 28, 2023 08:57
@dokmic dokmic requested a review from a team as a code owner July 28, 2023 08:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Copy link
Contributor

@gsoldevila gsoldevila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dokmic dokmic merged commit fcb592d into elastic:main Aug 1, 2023
@dokmic dokmic deleted the feature/156117 branch August 1, 2023 15:16
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 1, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 1, 2023
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.8
8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 1, 2023
…162648) (#162911)

# Backport

This will backport the following commits from `main` to `8.9`:
- [[Migrations] Unskip migration integration tests after fixing
(#162648)](#162648)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Michael
Dokolin","email":"mikhail.dokolin@elastic.co"},"sourceCommit":{"committedDate":"2023-08-01T15:16:07Z","message":"[Migrations]
Unskip migration integration tests after fixing
(#162648)","sha":"fcb592de8d88ad24eefc8783207738d7569db19d","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","Feature:Migrations","8.10
candidate","v8.10.0","v8.8.3","v8.9.1"],"number":162648,"url":"https://github.com/elastic/kibana/pull/162648","mergeCommit":{"message":"[Migrations]
Unskip migration integration tests after fixing
(#162648)","sha":"fcb592de8d88ad24eefc8783207738d7569db19d"}},"sourceBranch":"main","suggestedTargetBranches":["8.8","8.9"],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/162648","number":162648,"mergeCommit":{"message":"[Migrations]
Unskip migration integration tests after fixing
(#162648)","sha":"fcb592de8d88ad24eefc8783207738d7569db19d"}},{"branch":"8.8","label":"v8.8.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.9","label":"v8.9.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Michael Dokolin <mikhail.dokolin@elastic.co>
ThomThomson pushed a commit to ThomThomson/kibana that referenced this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.10 candidate Feature:Migrations release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.8.3 v8.9.1 v8.10.0
Projects
None yet
5 participants