Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Fix apm journey flakiness #162879

Conversation

achyutjhunjhunwala
Copy link
Contributor

@achyutjhunjhunwala achyutjhunjhunwala commented Aug 1, 2023

Summary

Closes #162813

Fix APM journey flakiness

Tested against Flaky Test runner - Passed 50/50

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@achyutjhunjhunwala achyutjhunjhunwala marked this pull request as ready for review August 1, 2023 10:44
@achyutjhunjhunwala achyutjhunjhunwala requested a review from a team as a code owner August 1, 2023 10:44
@achyutjhunjhunwala achyutjhunjhunwala self-assigned this Aug 1, 2023
@achyutjhunjhunwala achyutjhunjhunwala added Team:APM All issues that need APM UI Team support release_note:skip Skip the PR/issue when compiling release notes labels Aug 1, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM

@achyutjhunjhunwala achyutjhunjhunwala enabled auto-merge (squash) August 1, 2023 12:04
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @achyutjhunjhunwala

@achyutjhunjhunwala achyutjhunjhunwala merged commit 9eec3ae into elastic:main Aug 1, 2023
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Aug 1, 2023
@achyutjhunjhunwala achyutjhunjhunwala deleted the Fix-flakiness-for-apm-journey branch August 1, 2023 12:10
ThomThomson pushed a commit to ThomThomson/kibana that referenced this pull request Aug 1, 2023
## Summary

Closes elastic#162813

Fix APM journey flakiness

Tested against Flaky Test runner - [Passed
50/50](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2760)
@sorenlouv
Copy link
Member

@achyutjhunjhunwala When can we start seeing the results for this journey?

@achyutjhunjhunwala
Copy link
Contributor Author

@sqren we can already see the results. I have added the links of the dashboard on the original implementation ticket as part of test week. Currently on mobile and cannot search and link that ticket here

@sorenlouv
Copy link
Member

sorenlouv commented Aug 30, 2023

@achyutjhunjhunwala Is it documented somewhere. If not, can you please add it to https://github.com/elastic/kibana/tree/main/x-pack/plugins/apm ?

@achyutjhunjhunwala
Copy link
Contributor Author

Its documented here in the original implementation ticket - #153844 (comment)

But i will add it later to that APM Docs as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.10.0
Projects
None yet
7 participants