Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unskip license type functional test #163199

Merged

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Aug 4, 2023

Summary

  1. Unskip the provides changes in license types test
  2. Update the test license used to test enterprise

The flaky test runner has passed this test 50 times: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2839

Closes #53575

@tsullivan tsullivan force-pushed the licensing/unskip-license-change-test branch from 3beaa8f to d45a492 Compare August 9, 2023 16:35
@tsullivan tsullivan force-pushed the licensing/unskip-license-change-test branch from 362bcec to 273834d Compare August 9, 2023 18:17
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #148877 succeeded 362bcecea26aecf24cba805869a23b6d5fea197c
  • 💔 Build #147634 failed 3beaa8f9930928dd2cfbad911ddf532e4b47a3f0

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan marked this pull request as ready for review August 9, 2023 22:30
@tsullivan tsullivan added release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:License labels Aug 9, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@tsullivan tsullivan requested review from rudolf and a team August 9, 2023 22:32
@afharo
Copy link
Member

afharo commented Aug 10, 2023

Oops! I had the same changes on #163286 as I was looking at another related Skipped test issue 😅

Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you 🧡

@tsullivan tsullivan merged commit ea57cae into elastic:main Aug 10, 2023
6 checks passed
@tsullivan tsullivan deleted the licensing/unskip-license-change-test branch August 10, 2023 14:43
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Aug 10, 2023
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 10, 2023
* main: (108 commits)
  [Telemetry Schema Validation] Allow `null` on `string` (elastic#163499)
  [Search] Add Slack and Gmail connectors (elastic#163321)
  [ML] Provide hints for empty fields in dropdown options in Anomaly detection & Transform creation wizards, Change point detection view (elastic#163371)
  chore(slo): Add response required fields (elastic#163430)
  [AO] Fix add_to_case functional test (elastic#163155)
  unskip license type functional test (elastic#163199)
  fix(NA): yarn env vars for node_modules mirrors (elastic#163549)
  [Response Ops][Task Manager] Expose SLI metrics in HTTP API (elastic#162178)
  [Logs UI] Adapt test to ES highlighting changes and unskip (elastic#163592)
  [Infra UI] Implement Telemetry on 'Show' buttons within Inventory (elastic#163587)
  [Enterprise Search]Migrate all usages of EuiPage*_Deprecated (elastic#163482)
  fix(slo): settings and access for serverless (elastic#163514)
  [Infra UI] Implement telemetry for the asset details flyout (elastic#163078)
  [Fleet] Add a banner to the top of the Kafka Output UI to say that Elastic Defend integration is not supported (elastic#163579)
  [Fleet] Re-enable and fix Fleet policy secret integration tests (elastic#163428)
  [Fleet] add managed to imported saved object (elastic#163526)
  [Index Management] Disable index actions using contextRef (elastic#163475)
  [Discover] Inline shard failures warnings (elastic#161271)
  [Security Solution][Detection engine] skips geo_point non-ecs validation (elastic#163487)
  Update EUI layout components in bfetch example plugin (elastic#163490)
  ...
@afharo
Copy link
Member

afharo commented Aug 10, 2023

@tsullivan, can we backport this PR to solve #148313 (it was flagged for 7.17)?

tsullivan added a commit to tsullivan/kibana that referenced this pull request Aug 10, 2023
(cherry picked from commit ea57cae)

# Conflicts:
#	x-pack/test/licensing_plugin/server/updates.ts
@tsullivan
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@tsullivan
Copy link
Member Author

Sure @afharo: #163631

tsullivan added a commit that referenced this pull request Aug 11, 2023
# Backport

This will backport the following commits from `main` to `7.17`:
- [unskip license type functional test
(#163199)](#163199)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Tim
Sullivan","email":"tsullivan@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-08-10T14:43:05Z","message":"unskip
license type functional test
(#163199)","sha":"ea57caed71e5a9eca5325fc9e16f0bd34ebf3c7a","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","Feature:License","release_note:skip","backport:skip","v8.10.0"],"number":163199,"url":"https://github.com/elastic/kibana/pull/163199","mergeCommit":{"message":"unskip
license type functional test
(#163199)","sha":"ea57caed71e5a9eca5325fc9e16f0bd34ebf3c7a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/163199","number":163199,"mergeCommit":{"message":"unskip
license type functional test
(#163199)","sha":"ea57caed71e5a9eca5325fc9e16f0bd34ebf3c7a"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:License release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.17.13 v8.10.0
Projects
None yet
6 participants