[Security Solution] expandable flyout - expandable mode only for signal documents #163557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
release_note:enhancement
Team:Threat Hunting:Investigations
PhilippeOberti
force-pushed
the
expanded-flyout-only-for-signal
branch
from
ba6f9e8 to
e80b214
Compare
| > | ||
| <ExpandDetailButton /> | ||
| </div> | ||
| {flyoutIsExpandable && ( |
There was a problem hiding this comment.
consider adding some unit tests here
There was a problem hiding this comment.
the only reason I didn't add some is because we didn't have any for this file and I was being lazy.. But you're right, I will add them on Monday!
PhilippeOberti
force-pushed
the
expanded-flyout-only-for-signal
branch
from
e80b214 to
2f36733
Compare
christineweng
approved these changes
Aug 15, 2023
| } from './components/test_ids'; | ||
| import { mockFlyoutContextValue } from '../shared/mocks/mock_flyout_context'; | ||
|
|
||
| // jest.mock('../../common/components/link_to'); |
There was a problem hiding this comment.
remove commented line
PhilippeOberti
force-pushed
the
expanded-flyout-only-for-signal
branch
2 times, most recently
from
c26a613 to
95595b1
Compare
PhilippeOberti
force-pushed
the
expanded-flyout-only-for-signal
branch
from
95595b1 to
fe00ed4
Compare
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
hop-dev
pushed a commit
to hop-dev/kibana
that referenced
this pull request
Aug 16, 2023
bryce-b
pushed a commit
that referenced
this pull request
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The expandable flyout is going GA for 8.10, but not all of it. We're release the right panel and a few tabs in the left panel.
Currently the flyout can handle non
signaldocuments, but not gracefully as it was built for alerts specifically. More UI work is needed to correctly handle all other types (event.kind=alert,asset,enrichment,event,metric,stateandpipeline_error).This PR adds a small internal check to the expandable flyout which will hide the
Expand detailsbutton as well as theOverrviewtab if the fieldevent.kindof the viewed document isn'tsignal.Screen.Recording.2023-08-10.at.9.40.22.AM.mov
https://github.com/elastic/security-team/issues/6641