Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fleet pgpKeyPath as container env var #163783

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Add Fleet pgpKeyPath as container env var #163783

merged 1 commit into from
Aug 14, 2023

Conversation

joshdover
Copy link
Contributor

@joshdover joshdover commented Aug 14, 2023

Summary

Adds the xpack.fleet.packageVerification.gpgKeyPath config setting as an env var available in Kibana's container.

@joshdover joshdover requested a review from a team as a code owner August 14, 2023 09:02
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@joshdover joshdover added backport:all-open Backport to all branches that could still receive a release release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:all-open Backport to all branches that could still receive a release labels Aug 14, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #149967 succeeded dff4c0ccc9afa4d1a7da68a88e3c7342070c1944

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@joshdover joshdover merged commit 26a9739 into main Aug 14, 2023
@joshdover joshdover deleted the fleet-env-var branch August 14, 2023 18:41
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 14, 2023
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 14, 2023
# Backport

This will backport the following commits from `main` to `8.9`:
- [Add Fleet pgpKeyPath as container env var
(#163783)](#163783)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Josh
Dover","email":"1813008+joshdover@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-08-14T18:41:19Z","message":"Add
Fleet pgpKeyPath as container env var
(#163783)","sha":"26a9739beecd9dddd30c438dc42f56aef91e3ef6","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Fleet","backport:prev-minor","v8.10.0"],"number":163783,"url":"https://github.com/elastic/kibana/pull/163783","mergeCommit":{"message":"Add
Fleet pgpKeyPath as container env var
(#163783)","sha":"26a9739beecd9dddd30c438dc42f56aef91e3ef6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/163783","number":163783,"mergeCommit":{"message":"Add
Fleet pgpKeyPath as container env var
(#163783)","sha":"26a9739beecd9dddd30c438dc42f56aef91e3ef6"}}]}]
BACKPORT-->

Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
@mistic mistic added v8.9.2 and removed v8.9.1 labels Aug 17, 2023
@mistic
Copy link
Member

mistic commented Aug 17, 2023

This pr didn't make it into the build candidate for v8.9.1. Updating the labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team v8.9.2 v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants