[OAS] Add is_system_action to connector responses #163969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview: |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
lcawl
added
Team:ResponseOps
|
Pinging @elastic/response-ops (Team:ResponseOps) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
adcoelho
reviewed
Aug 17, 2023
There was a problem hiding this comment.
What about components/schemas/connector_response_properties.yaml?
It is used in s@{spaceid}@api@actions@connector.yaml and it seems it might be missing the is_system_action property too. (The example response for that API also has it create_index_connector_response.yaml.)
adcoelho
approved these changes
Aug 17, 2023
That file just points to all the connector-specific files, which contain the change, so I think we're good.
Yes, that example has been updated and passes validation so it's correctly matching the spec. |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
lcawl
added a commit
to lcawl/kibana
that referenced
this pull request
Aug 23, 2023
(cherry picked from commit 5c1d118)
lcawl
added a commit
that referenced
this pull request
Aug 24, 2023
…164642) # Backport This will backport the following commits from `main` to `8.10`: - [[OAS] Add is_system_action to connector responses (#163969)](#163969) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Lisa Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2023-08-17T20:13:35Z","message":"[OAS] Add is_system_action to connector responses (#163969)","sha":"5c1d118c36a9d6cc572fb49326a9d059da73d1fc","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","Team:ResponseOps","Feature:Actions/ConnectorsManagement","v8.10.0","v8.11.0"],"number":163969,"url":"#163969 Add is_system_action to connector responses (#163969)","sha":"5c1d118c36a9d6cc572fb49326a9d059da73d1fc"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"#163969 Add is_system_action to connector responses (#163969)","sha":"5c1d118c36a9d6cc572fb49326a9d059da73d1fc"}},{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relates to #160367
This PR updates the openAPI specification for connectors to include the new
is_system_actionproperty.