Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard Navigation] Drilldown on link click #164196

Merged
merged 35 commits into from
Sep 5, 2023
+920 −367
Merged

[Dashboard Navigation] Drilldown on link click #164196

Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
c367b7b
Make dashboard drilldown options a separate component
Heenawter Aug 17, 2023
461feb9
Fix linting
Heenawter Aug 17, 2023
f7e8309
Rename the component
Heenawter Aug 17, 2023
ec4b98e
Add URL options toggles
Heenawter Aug 17, 2023
3953b4f
Add `options` to links
Heenawter Aug 17, 2023
c8d4ab5
First draft of dashboard-to-dashboard links working
Heenawter Aug 21, 2023
4712e57
Fix linting
Heenawter Aug 21, 2023
8e6f266
Another attempt at fixing CI
Heenawter Aug 22, 2023
fd57408
First draft of external URLs working
Heenawter Aug 22, 2023
185f507
Clean up + fix memory leak
Heenawter Aug 23, 2023
5b56e6e
Clean up imports
Heenawter Aug 23, 2023
5dd848b
Rename constants + more clean up
Heenawter Aug 23, 2023
5a1b14f
Final clean up
Heenawter Aug 24, 2023
6e3b3d4
First draft of URL validation
Heenawter Aug 24, 2023
21b2265
Clean up validation
Heenawter Aug 28, 2023
efc4d10
More "final" cleanup :)
Heenawter Aug 28, 2023
938aca2
Merge branch 'navigation-embeddable' of github.com:elastic/kibana int…
Heenawter Aug 28, 2023
426d6e2
`i18n` for missed options string
Heenawter Aug 28, 2023
c01a4d4
Fix Firefox shift+click bug
Heenawter Aug 28, 2023
8fc7bd4
Clean up dashboard links logic
Heenawter Aug 28, 2023
4430c00
Keep options consistent on link type change
Heenawter Aug 29, 2023
895907c
Fix external links not opening in new tab
Heenawter Aug 30, 2023
8f3458a
Fix bug where error state stuck around on link type change
Heenawter Aug 30, 2023
c13723c
Remember destinations on link type change
Heenawter Aug 30, 2023
2f58c31
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine Aug 30, 2023
6edfa42
Switch tooltip to show custom label rather than dashboard title, if p…
Heenawter Aug 31, 2023
b07e180
Update x-pack/plugins/dashboard_enhanced/public/services/drilldowns/a…
Heenawter Aug 31, 2023
a7d719a
Update x-pack/plugins/dashboard_enhanced/public/services/drilldowns/a…
Heenawter Aug 31, 2023
7f28cca
Fix color prop to display correctly in Safari
nickpeihl Aug 31, 2023
eb2e41d
Merge branch 'navigation-embeddable' of github.com:elastic/kibana int…
Heenawter Aug 31, 2023
0d7df01
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Aug 31, 2023
3ca397b
Fix URL schema + add validation at component level
Heenawter Aug 31, 2023
014d9e4
Merge branch 'nav-link-drilldown_2023-08-16' of github.com:heenawter/…
Heenawter Aug 31, 2023
0ba8b89
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Aug 31, 2023
6ebc2b1
Update src/plugins/navigation_embeddable/public/components/dashboard_…
nickpeihl Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...ugins/navigation_embeddable/public/components/dashboard_link/dashboard_link_component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,10 @@ export const DashboardLinkComponent = ({
};
}
return {
tooltipTitle: Boolean(dashboardDescription) ? dashboardTitle : undefined,
tooltipMessage: dashboardDescription || dashboardTitle,
tooltipTitle: Boolean(dashboardDescription) ? linkLabel : undefined,
tooltipMessage: dashboardDescription || linkLabel,
};
}, [error, dashboardTitle, dashboardDescription]);
}, [error, linkLabel, dashboardDescription]);
Copy link
Contributor Author

@Heenawter Heenawter Aug 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figured I might as well quickly make this change per the offline tooltip description, since it's such a tiny change - previously, we were always showing the saved object title in the tooltip; now, we default to the custom label, if provided. This means that the link label and the tooltip will always display the same value


/**
* Dashboard-to-dashboard navigation
Expand Down