Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where ESC was closing the Console autocompletion suggestions menu, but then also exiting edit mode #16500

Merged

Conversation

cjcenizal
Copy link
Contributor

Fixes #16139

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cjcenizal cjcenizal merged commit e5a10ed into elastic:master Feb 3, 2018
@cjcenizal cjcenizal deleted the prevent-default-esc-console-menu branch February 3, 2018 00:01
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Feb 3, 2018
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Feb 3, 2018
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Feb 3, 2018
cjcenizal added a commit that referenced this pull request Feb 3, 2018
cjcenizal added a commit that referenced this pull request Feb 3, 2018
cjcenizal added a commit that referenced this pull request Feb 3, 2018
jbudz added a commit that referenced this pull request Feb 6, 2018
…estions menu, but then also exiting edit mode. (#16500) (#16504)"

This reverts commit 5c9d808.
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Feb 7, 2018
cjcenizal added a commit that referenced this pull request Feb 9, 2018
@timroes timroes added v6.2.2 and removed 6.2.2 labels Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants