Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AO][SERVERLESS] Enable tests after swapping to ESS #165570

Closed

Conversation

fkanout
Copy link
Contributor

@fkanout fkanout commented Sep 4, 2023

Summary

It fixes #165569

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 4, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #13 / maps app map saved object management read "after all" hook for "should override time stored with map when query is provided in global state"
  • [job] [logs] FTR Configs #13 / maps app map saved object management read "before all" hook for "should update global Kibana time to value stored with map"
  • [job] [logs] Serverless Search Tests / serverless common UI home page has project header
  • [job] [logs] Serverless Observability Tests / Serverless observability API - feature flags Threshold Rule Threshold rule - DOCUMENTS_COUNT - FIRED Rule creation should set correct information in the alert document

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.6MB 12.6MB +6.4KB
securitySolutionServerless 260.1KB 266.4KB +6.2KB
total +12.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolutionServerless 39.7KB 39.7KB +1.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@fkanout fkanout closed this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x-pack/test_serverless/api_integration/test_suites/observability/threshold_rule/group_by_fired.ts
3 participants