Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data Views] Unskip data view field editor Serverless tests #166408

Merged
merged 5 commits into from
Sep 19, 2023
Merged

[Data Views] Unskip data view field editor Serverless tests #166408

merged 5 commits into from
Sep 19, 2023

Conversation

davismcphee
Copy link
Contributor

@davismcphee davismcphee commented Sep 14, 2023 •
edited
Loading

Summary

This PR unskips the data view field editor Serverless tests. I ran 100x flaky test runs against each project type to confirm they should no longer be flaky.

Flaky test runs:

Resolves #165384.

Checklist

For maintainers

@davismcphee davismcphee added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Sep 14, 2023
@davismcphee davismcphee self-assigned this Sep 14, 2023
@davismcphee davismcphee marked this pull request as ready for review September 15, 2023 20:55
@davismcphee davismcphee requested a review from a team as a code owner September 15, 2023 20:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

jughosta
jughosta reviewed Sep 16, 2023
View reviewed changes
...st_serverless/functional/test_suites/common/examples/data_view_field_editor_example/index.ts
method: 'POST',
body: { user: 'matt', message: 20 },
},
// TODO: Extend timeout in Serverless
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// TODO: Extend timeout in Serverless
// Extend timeout in Serverless

...st_serverless/functional/test_suites/common/examples/data_view_field_editor_example/index.ts
before(async () => {
// TODO: Serverless tests require login first
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// TODO: Serverless tests require login first
// Serverless tests require login first

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #56 / serverless security UI Configure Case "before all" hook in "Configure Case"

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @davismcphee

@davismcphee davismcphee merged commit 447a56a into elastic:main Sep 19, 2023
@davismcphee davismcphee deleted the unskip-data-view-field-editor branch September 19, 2023 03:08
@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Sep 19, 2023
@watson watson added the Project:Serverless Work as part of the Serverless project for its initial release label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jughosta jughosta jughosta approved these changes

Assignees

@davismcphee davismcphee

Labels
backport:skip This commit does not require backporting Project:Serverless Work as part of the Serverless project for its initial release release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.11.0
Projects
None yet
Milestone
No milestone
6 participants
@davismcphee @elasticmachine @kibana-ci @jughosta @watson @kibanamachine